Repository navigation
ci: add PHP 8.5 and non-blocking PHP 8.6 matrix legs - #872
Conversation
Mirror Cacti/cacti#8633: run PHP 8.5 and 8.6 as experimental (non-blocking) matrix legs via continue-on-error so bleeding-edge toolchain gaps do not turn CI red. PHP 8.5 is provisioned through shivammathur/setup-php as usual. PHP 8.6 is still pre-release and the setup-php nightly ships ABI-skewed bundled extensions, so the 8.6 leg provisions a coherent CLI from Ondrej Sury's PPA instead. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
🟡 Changes recommended
The PHP 8.6 CI path lacks a coverage driver despite requesting coverage, causing the test step to fail and preventing the subsequent poller integration check from running.
1 open issue
What changed in this PR
This PR expands the plugin’s integration-test matrix to check newer PHP versions without making experimental failures block CI.
Changes:
- Adds non-blocking PHP 8.5 and 8.6 jobs while keeping PHP 8.2–8.4 blocking.
- Uses setup-php for PHP 8.5 and a separate PPA-based installation for PHP 8.6 to avoid the reported extension ABI mismatch.
- Configures PHP 8.6 CLI defaults and ensures Composer is available.
| File | Description |
|---|---|
.github/workflows/plugin-ci-workflow.yml |
Adds experimental matrix jobs and a dedicated PHP 8.6 provisioning path. |
Review effort: Balanced
The Ondřej PPA has no php8.6-xdebug build yet, so the experimental 8.6 leg has no coverage driver and the patch-coverage gate cannot read a clover report. All 8.6 tests pass, so skip only the coverage-enforcement step on 8.6; the 8.5 leg keeps it (setup-php provides xdebug there). Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Experiment: provide a real coverage driver on the pre-release 8.6 leg by building Xdebug from PECL (Xdebug >= 3.5 supports PHP 8.5/8.6), since the Ondrej PPA has no php8.6-xdebug package yet. With a driver present the patch-coverage gate and coverage-dependent tests run the same as the setup-php legs, so the 8.6 coverage-skip is removed. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Xdebug does not support PHP 8.6 yet (Xdebug 3.5.3 requires < 8.6.0) and the Ondrej PPA ships no php8.6-xdebug, so the 8.6 leg has no coverage driver at all. Skip only the coverage-enforcement step on 8.6; the 8.5 leg keeps it via setup-php's xdebug. Reverts the PECL build experiment. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Use the runner effective group alongside the www-data user so newly created RRD files match the existing CI directory ownership. Covers flat and structured RRD paths without changing directory modes or suppressing warnings. Signed-off-by: Thomas Vincent <thomasvincent@gmail.com>
bmfmancini
left a comment
There was a problem hiding this comment.
Reviewed. The workflow change matches the rest of the fleet: non-blocking 8.5/8.6 legs, 8.6 from the Ondřej PPA with the coverage gate skipped there, and the poller run as www-data with the runner group. All checks are green, including both new legs.
ubuntu-latest has rolled to Ubuntu 26.04 (Resolute). Ondrej Surys Launchpad PPA (ppa:ondrej/php) has no Release file for the resolute suite yet (it is migrating to packages.sury.org), so apt-get update 404s and the experimental 8.6 PPA toolchain install dies with exit code 100. Pin the experimental 8.6 leg to ubuntu-24.04 (Noble), which still serves the latest packaged 8.6 release candidate from the PPA. The other legs use shivammathur/setup-php and are unaffected. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Move PHP 8.5 from the non-blocking experimental include leg into the required base matrix. 8.5 is a stable release provisioned via shivammathur/setup-php like the other required legs, so it no longer needs continue-on-error. Only PHP 8.6 (still a pre-release installed from Ondrej Surys PPA, pinned to ubuntu-24.04) remains experimental. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
|




What
Adds PHP 8.5 as a required leg and PHP 8.6 as a non-blocking (experimental) leg to the plugin integration-test matrix, mirroring the method used in Cacti/cacti#8633.
How
continue-on-error: ${{ matrix.experimental }}to the job andexperimental: [false]to the base matrix.8.5to the required base matrix and keep aninclude:leg for8.6withexperimental: true, so only the bleeding-edge 8.6 toolchain can ever turn CI red.shivammathur/setup-phpas usual.undefined symbol: smart_str_ferealloc/_safe_femalloc), so the 8.6 leg provisions a coherent CLI from Ondřej Surý's PPA instead, keeping the CLI on one ABI-matched build.Notes
Co-authored-by: Copilot 223556219+Copilot@users.noreply.github.com