Skip to content

fix: fit message previews to the available column width - #462

Open
somethingwithproof wants to merge 1 commit into
developfrom
fix/message-preview-column-width
Open

somethingwithproof wants to merge 1 commit into
developfrom
fix/message-preview-column-width

Conversation

@somethingwithproof

Copy link
Copy Markdown
Member

Description

Render the full escaped message in the preview button so the existing CSS ellipsis uses the available column width. This removes the hardcoded 100-character cut while preserving the single-line layout and full-message details pane.

Related Issue

Fixes #461.

How Has This Been Tested?

The new ASCII, Unicode and HTML-like message cases fail on the original code and pass with the fix. Docker PHP 8.2: 670 tests passed (2785 assertions), with one existing process-helper /proc warning. The workspace browser test passed at 1600px and 390px, including text beyond character 100, CSS overflow/ellipsis, details, escaped markup and no page overflow. PHP/JavaScript syntax, manifest and diff checks passed. The existing browser fixture was refreshed for current realm helpers and its selection-color check now compares the same hover state.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation repository accordingly.

Signed-off-by: Thomas Vincent <thomasvincent@gmail.com>
@sonarqubecloud

Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Message previews truncate at 100 characters despite available column space

1 participant