Repository navigation
fix: fit message previews to the available column width - #462
Open
somethingwithproof wants to merge 1 commit into
Open
somethingwithproof wants to merge 1 commit into
somethingwithproof wants to merge 1 commit into
Conversation
Signed-off-by: Thomas Vincent <thomasvincent@gmail.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Description
Render the full escaped message in the preview button so the existing CSS ellipsis uses the available column width. This removes the hardcoded 100-character cut while preserving the single-line layout and full-message details pane.
Related Issue
Fixes #461.
How Has This Been Tested?
The new ASCII, Unicode and HTML-like message cases fail on the original code and pass with the fix. Docker PHP 8.2: 670 tests passed (2785 assertions), with one existing process-helper
/procwarning. The workspace browser test passed at 1600px and 390px, including text beyond character 100, CSS overflow/ellipsis, details, escaped markup and no page overflow. PHP/JavaScript syntax, manifest and diff checks passed. The existing browser fixture was refreshed for current realm helpers and its selection-color check now compares the same hover state.Types of changes
Checklist