Skip to content

fix: avoid PHP 8.6 deprecations in schema caching - #457

Merged
TheWitness merged 1 commit into
developfrom
fix/schema-cache-php86
Nov 17, 2026
Merged

TheWitness merged 1 commit into
developfrom
fix/schema-cache-php86

Conversation

@somethingwithproof

Copy link
Copy Markdown
Member

Fixes #456.

Use spl_object_id() for the request-local schema cache key to avoid PHP 8.6 deprecation warnings during Syslog page loads. Cached definitions retain their connection objects; a regression test checks that one connection’s successful creation does not skip another connection’s schema check. No SQL or schema changes.

Validation: seven schema compatibility tests passed on PHP 8.2 and 8.5 (25 assertions each); PHP 7.4 syntax check passed. The broader local suite exposed an existing missing-procfs warning and a container PID-1 assumption in the process-helper tests; those are outside this change. PHP 8.6 behavior will be checked by the existing CI matrix.

Signed-off-by: Thomas Vincent <thomasvincent@gmail.com>
@sonarqubecloud

Copy link
Copy Markdown

@TheWitness
TheWitness merged commit 6c8238f into develop Nov 17, 2026
8 checks passed
@TheWitness
TheWitness deleted the fix/schema-cache-php86 branch November 17, 2026 03:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Avoid PHP 8.6 deprecations in schema connection caching

2 participants