Skip to content

fix: stream s3 proxy request body instead of buffering in memory #226

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
CodeMaster4711 merged 1 commit into from
Sep 6, 2026
Merged

fix: stream s3 proxy request body instead of buffering in memory #226

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 3 additions & 11 deletions control-plane/api-gateway/src/routes/s3_proxy.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,21 +106,13 @@ async fn proxy(
let reqwest_method =
reqwest::Method::from_bytes(method.as_str().as_bytes()).unwrap_or(reqwest::Method::GET);

let body_bytes = axum::body::to_bytes(body, usize::MAX).await.map_err(|e| {
(
StatusCode::BAD_REQUEST,
Json(json!({ "error": format!("failed to read request body: {}", e) })),
)
})?;
let body_stream = body.into_data_stream();
let request_body = reqwest::Body::wrap_stream(body_stream);

let client = reqwest::Client::new();
let mut request = client.request(reqwest_method, &url).body(body_bytes);
let mut request = client.request(reqwest_method, &url).body(request_body);

for (key, value) in headers.iter() {
let key_lower = key.as_str().to_lowercase();
if key_lower == "content-length" {
continue;
}
if let Ok(value_str) = value.to_str() {
request = request.header(key.as_str(), value_str);
}
Expand Down
Loading