Repository navigation
Conversation
inner (loft) and inset.by (sketch) do take a number directly, but the guide implied that was the only way, when exprs.inner and exprs.inset already drive the same wall from a named parameter. Fixes CNCKitchen#59. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Contributor
|
Thank you for the pull request. ScanRuler is dual-licensed (AGPL and commercial), which only works if its author may license every line of it, so a short Contributor License Agreement is needed once. You keep your copyright. To sign, reply with the sentence below exactly: I agree to CLA.md You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
inner(loft) andinset.by(sketch) do take a wall as a plain number, but the guide's wording implied that was the only way.exprs.inneron the loft andexprs.inseton an inset sketch already drive that same wall from a named parameter, taken again from its station when the parameter changes — this was already true in the source (reSchemas.ts,reFeatureInput.ts) and in the CHANGELOG ("Expressions on every number", 2026-10-24), just not reflected inscan-to-cad.md.Fixes #59.
Test plan