Repository navigation
Conversation
Contributor
|
Thank you for the pull request. ScanRuler is dual-licensed (AGPL and commercial), which only works if its author may license every line of it, so a short Contributor License Agreement is needed once. You keep your copyright. To sign, reply with the sentence below exactly: I agree to CLA.md You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Switching workspaces currently changes the layout and where controls live, and a scanner owner learning the app has to assemble the measurement workflow from individual hints. This draft proposes a shared layout across all six workspaces and an optional guide that follows actual imports, fits, dimensions, history and project downloads.
This is a complete implementation offered for design and integration review. I would like feedback on the overall direction before treating it as ready for adoption.
Behavior
Commit structure and related PRs
Based on current main,
5c1f2f9(0.9.4), including its sample scan, small-feature rendering, Mac modifier handling and note provenance changes.The first two commits carry prerequisite fixes already proposed independently in #31 (modal focus/keyboard isolation) and #70 (reverse-note CSS leaking into 2D labels). They are kept separate so they can be applied independently and removed from this series once upstream includes them. Subsequent commits introduce the Measure shell, fix its start-pane width, extend it across the remaining workspaces, and document the workflow.
Other bug-fix PRs remain separate: this series does not include the mesh-welding, replacement-import, 3MF-worker/archive or preview-depth changes from #22, #23, #32 and #40. Local automation files and private review records are excluded.
Review locally
In a clone of this repository:
Validation
npm test -- --maxWorkers=2passed; unavailable/private fixtures retain their existing skips.npm --prefix mcp test: 127 tests passed, using current upstream's lockfile dependencies.npm run build: TypeScript and production build passed.npm run e2e:ci: exit 0; 25 browser suites executed successfully. The additional private scooter-cover check was skipped because its scan is unavailable.Integration checks exposed two harness assumptions: native Select All in headless Mac number fields and coordinates cached before a tool panel resized the canvas. The harness now sends the native editing command and projects the same world-space ray into the resized canvas. Original geometry assertions and tolerances remain unchanged. A real phone overlap introduced by combining both sample choices was also reproduced and fixed by placing empty-state content and wrapped viewport controls in separate layout rows.
Browser verification uses isolated headless Chrome profiles and synthetic fixtures. Physical scanner accuracy, Safari/Firefox, physical touch/pen/SpaceMouse hardware and human novice testing have not been verified. No performance gain is claimed for this proposal.
Screenshots
Element editing
Guided measurement
Surface deviation in dark mode
Phone tool sheet