Skip to content

Conversation

@JamesDemeryNava
Copy link
Contributor

JIRA Ticket:
BB2-4259

What Does This PR Do?

Adds v3 EOB details to the swagger documentation. I also sourced new examples for EOB v3, as from what I understand it differs slightly from v2 (at least in terms of the id that is passed for read EOB calls).

What Should Reviewers Watch For?

If you're reviewing this PR, please check for these things in particular:

  • Does adding entirely new examples for this make sense? Should we just repurpose the v2 EOB examples give how large of an update this is, while making sure that the example ID that we pass for v3 EOB read calls matches what is passed for v3 instead of v2?

Validation

  • Are you able to load the swagger docs locally, and see EOB search and read call details?
  • Do the new examples for EOB v3 look correct/well-formed?
  • I ran actual v3 EOB read/search calls for BBUser09003 to get these examples, is that acceptable?

What Security Implications Does This PR Have?

Please indicate if this PR does any of the following:

  • Adds any new software dependencies
  • Modifies any security controls
  • Adds new transmission or storage of data
  • Any other changes that could possibly affect security?
  • Yes, one or more of the above security implications apply. This PR must not be merged without the ISSO or team
    security engineer's approval.

Any Migrations?

  • Yes, there are migrations
    • The migrations should be run PRIOR to the code being deployed
    • The migrations should be run AFTER the code is deployed
    • There is a more complicated migration plan (downtime,
      etc)
  • No migrations

@jimmyfagan jimmyfagan assigned jimmyfagan and bwang-icf and unassigned jimmyfagan Dec 8, 2025
@bwang-icf
Copy link
Contributor

Checked via https://editor.swagger.io/ and looked good!

@JamesDemeryNava JamesDemeryNava merged commit 78de828 into master Dec 9, 2025
8 checks passed
@JamesDemeryNava JamesDemeryNava deleted the jamesdemery/BB2-4259-v3-eob-swagger-updates branch December 9, 2025 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants