Skip to content

changing base images and upgrading vite - #142

Merged
bwang-icf merged 3 commits into
masterfrom
brandon/BB2-5176-dependency-upgrades
Sep 16, 2026
Merged

bwang-icf merged 3 commits into
masterfrom
brandon/BB2-5176-dependency-upgrades

Conversation

@bwang-icf

Copy link
Copy Markdown
Contributor

JIRA Ticket:
BB2-5176

What Does This PR Do?
Changes out the base images to upgraded/alternate versions and bumps other dependencies up

What Should Reviewers Watch For?
It is known that the insurance card portion is broken at the moment. That will need an SDK deployment to resolve. Otherwise, any other breaking portions of the local run should be looked for.

Validation
Verified with local run

@JamesDemeryNava

Copy link
Copy Markdown
Contributor

@bwang-icf are there any steps needed in this branch before running docker-compose up -d? Asking as when I run that now, I get a failure on:

creating build container: unable to copy from source docker://node:26.9.0-alpine3.24: initializing source docker://node:26.9.0-alpine3.24: reading manifest 26.9.0-alpine3.24 in docker.io/library/node: manifest unknown

Did you run into that?

@bwang-icf

Copy link
Copy Markdown
Contributor Author

@JamesDemeryNava My bad I had fat fingered the 9 instead of 7. There isn't such a version yet for the alpine image. I'm going to change that out.

@bwang-icf

Copy link
Copy Markdown
Contributor Author

@JamesDemeryNava I've got the proper base images up now, but the calls for the insurance card response won't work until the SDKs are deployed with the changes. I could add a bit here to treat that more loosely so that it will still work at runtime, or we could deploy the SDKs and then there would not need to be changes to the index.ts at all. For reference, I would be changing L105 to

const insuranceCardResults = await (bb as any).getInsuranceCardData(authToken);

We could clean that up right after the SDK deployment as well.

@JamesDemeryNava

Copy link
Copy Markdown
Contributor

@JamesDemeryNava I've got the proper base images up now, but the calls for the insurance card response won't work until the SDKs are deployed with the changes. I could add a bit here to treat that more loosely so that it will still work at runtime, or we could deploy the SDKs and then there would not need to be changes to the index.ts at all. For reference, I would be changing L105 to

const insuranceCardResults = await (bb as any).getInsuranceCardData(authToken);

We could clean that up right after the SDK deployment as well.

I think it's fine if insurance card response doesn't work until the SDKs are deployed 🤷‍♂️ up to you if you want to push that change here or not.

@bwang-icf

Copy link
Copy Markdown
Contributor Author

Gotcha okay. I think then I will push it without that change and leave it broken for now and then once the SDK is out, I'll check this again.

@JamesDemeryNava

Copy link
Copy Markdown
Contributor

@bwang-icf do you know how I can verify that perl has been updated to the requested version?

@bwang-icf

Copy link
Copy Markdown
Contributor Author

@JamesDemeryNava Server doesn't build right without that other bit in there, so I'm adding that line back in for now. The alpine images just don't have perl outright, so to check, I exec'ed into them and tried

which perl

which return nothing and

perl --version

which returns an error saying that perl isn't there, which is what we expect.

@JamesDemeryNava

Copy link
Copy Markdown
Contributor

@JamesDemeryNava Server doesn't build right without that other bit in there, so I'm adding that line back in for now. The alpine images just don't have perl outright, so to check, I exec'ed into them and tried

which perl

which return nothing and

perl --version

which returns an error saying that perl isn't there, which is what we expect.

Got it, thanks!

@JamesDemeryNava JamesDemeryNava left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Was able to get through, and with using the latest from node-sdk (feature branch for 5195/5196), I could see the insurance card info. Once security signs off, good to go!

@sb-DarenDean

Copy link
Copy Markdown

LGTM! No concerns

@bwang-icf
bwang-icf merged commit 1b2ab7b into master Sep 16, 2026
3 checks passed
@bwang-icf
bwang-icf deleted the brandon/BB2-5176-dependency-upgrades branch September 16, 2026 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants