changing base images and upgrading vite - #142
Conversation
|
@bwang-icf are there any steps needed in this branch before running docker-compose up -d? Asking as when I run that now, I get a failure on: creating build container: unable to copy from source docker://node:26.9.0-alpine3.24: initializing source docker://node:26.9.0-alpine3.24: reading manifest 26.9.0-alpine3.24 in docker.io/library/node: manifest unknown Did you run into that? |
|
@JamesDemeryNava My bad I had fat fingered the 9 instead of 7. There isn't such a version yet for the alpine image. I'm going to change that out. |
|
@JamesDemeryNava I've got the proper base images up now, but the calls for the insurance card response won't work until the SDKs are deployed with the changes. I could add a bit here to treat that more loosely so that it will still work at runtime, or we could deploy the SDKs and then there would not need to be changes to the index.ts at all. For reference, I would be changing L105 to
We could clean that up right after the SDK deployment as well. |
I think it's fine if insurance card response doesn't work until the SDKs are deployed 🤷♂️ up to you if you want to push that change here or not. |
|
Gotcha okay. I think then I will push it without that change and leave it broken for now and then once the SDK is out, I'll check this again. |
|
@bwang-icf do you know how I can verify that perl has been updated to the requested version? |
|
@JamesDemeryNava Server doesn't build right without that other bit in there, so I'm adding that line back in for now. The alpine images just don't have perl outright, so to check, I exec'ed into them and tried
which return nothing and
which returns an error saying that perl isn't there, which is what we expect. |
Got it, thanks! |
JamesDemeryNava
left a comment
There was a problem hiding this comment.
Looks good! Was able to get through, and with using the latest from node-sdk (feature branch for 5195/5196), I could see the insurance card info. Once security signs off, good to go!
|
LGTM! No concerns |
JIRA Ticket:
BB2-5176
What Does This PR Do?
Changes out the base images to upgraded/alternate versions and bumps other dependencies up
What Should Reviewers Watch For?
It is known that the insurance card portion is broken at the moment. That will need an SDK deployment to resolve. Otherwise, any other breaking portions of the local run should be looked for.
Validation
Verified with local run