Fix Call Home reconnect - #626
Merged
Merged
Conversation
Use a self-pipe instead of a cond var to allow poll()ing the pending Call Home socket during the reconnect wait. Detects when the peer closes a pending connection and prevents dead sockets from reaching the SSH/TLS handshake. Fixes #625
michalvasko
approved these changes
Aug 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Call Home reconnect wait used a condition variable, which could not monitor the pending socket. If the TCP handshake completed during the wait and the peer then closed, the dead socket was passed to the SSH/TLS handshake, causing:
SSH key exchange error (Socket error: No such file or directory).Replace the cond var with a self-pipe so
poll()can wait on both the stop signal and the pending socket simultaneously. A peer-closed pending socket is now detected viaPOLLHUP/POLLERRand discarded before reaching the handshake.Also moves
sock_pendingout of the endpoint config struct to a thread-local variable, fixing a leak when the endpoint was removed mid-connection.Fixes #625