Skip to content

fdsdump: dont assume we are on 64bit architecture when formatting time #133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sedmicha merged 1 commit into from
Jul 1, 2026
Merged

fdsdump: dont assume we are on 64bit architecture when formatting time #133

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 4 additions & 5 deletions src/tools/fdsdump/src/aggregator/print.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@
#include <sys/socket.h>

#include <cctype>
#include <cinttypes>
#include <iostream>

namespace fdsdump {
Expand Down Expand Up @@ -61,7 +62,6 @@ std::string
datetime_to_str(uint64_t ts_millisecs)
{
char buffer[128];
static_assert(sizeof(uint64_t) == sizeof(time_t), "Assumed that time_t is uint64_t, but it's not");

uint64_t secs = ts_millisecs / 1000;
uint64_t msecs_part = ts_millisecs % 1000;
Expand All @@ -71,13 +71,12 @@ datetime_to_str(uint64_t ts_millisecs)
msecs_part *= 10;
}

time_t t_secs = std::min<time_t>(secs, std::numeric_limits<time_t>::max());
tm tm;
localtime_r(reinterpret_cast<time_t *>(&secs), &tm);
//TODO: The format should probably be configrable
//TODO: Have a look at the hard coded buffer size
localtime_r(&t_secs, &tm);
std::size_t n = strftime(buffer, sizeof(buffer), "%Y-%m-%d %H:%M:%S", &tm);
assert(n > 0);
snprintf(&buffer[n], sizeof(buffer) - n, ".%03lu", msecs_part);
snprintf(&buffer[n], sizeof(buffer) - n, ".%03" PRIu64, msecs_part);

return buffer;
}
Expand Down
Loading