Skip to content

Rr 95 use logging#99

Open
ryanraaschCDC wants to merge 8 commits into
mainfrom
rr-95-use-logging
Open

Rr 95 use logging#99
ryanraaschCDC wants to merge 8 commits into
mainfrom
rr-95-use-logging

Conversation

@ryanraaschCDC

Copy link
Copy Markdown
Collaborator

No description provided.

@ryanraaschCDC ryanraaschCDC requested a review from Copilot June 24, 2026 14:27
@ryanraaschCDC ryanraaschCDC linked an issue Jun 24, 2026 that may be closed by this pull request

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates cfa.dataops.catalog to use Python’s logging instead of print() for user-facing informational messages, and threads a print_version flag through get_dataframe() to control version messaging.

Changes:

  • Replaced several print() calls with logger.warning() / logger.info().
  • Added print_version parameter to get_dataframe() overloads and implementation, and passed it through to version resolution / blob reads.
  • Introduced module-level logging configuration and a module logger.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread cfa/dataops/catalog.py Outdated
Comment thread cfa/dataops/catalog.py Outdated
Comment thread cfa/dataops/catalog.py Outdated
Comment thread cfa/dataops/catalog.py
Comment thread cfa/dataops/catalog.py
Comment thread cfa/dataops/catalog.py
Comment thread cfa/dataops/catalog.py
Comment thread cfa/dataops/catalog.py Outdated
Comment thread cfa/dataops/catalog.py
ryanraaschCDC and others added 3 commits June 24, 2026 16:19
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 3 comments.

Comment thread cfa/dataops/catalog.py Outdated
Comment thread cfa/dataops/catalog.py Outdated
Comment thread cfa/dataops/catalog.py
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Use logging instead of printing

4 participants