You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This PR will expand the SIST scientific regression suite to cover all supported calculation modes for the 1.0.0 release.
The existing competition regression coverage has been extended with maintained baselines for melting, Z-DNA, and cruciform calculations so that future numerical drift can be detected across the supported scientific workflows.
Changes
Scientific regression baselines:
Add maintained 1.0.0 reference outputs for melting, Z-DNA, and cruciform calculations.
Retain the existing competition reference outputs and historical inherited output for provenance.
Document the supported scientific regression baselines and how reference updates should be handled.
Shared SIST test execution:
Generalise the test fixture infrastructure so all supported SIST calculation modes use the same execution path.
Add parameterised execution for melting, Z-DNA, and cruciform calculations.
Reuse the same controlled input sequence and temporary maintained-source build for all regression cases.
Regression and CLI coverage:
Add CLI checks for the individual transition calculations.
Compare deterministic scientific metrics against the versioned 1.0.0 baselines.
Compare every reported sequence position, base, transition probability, and energy value where applicable.
Continue comparing competition P_melt, P_Z, and P_cruciform values across the full sequence.
Ignore only the variable Run time value during scientific regression comparison.
Impact
All supported SIST scientific calculation modes are now covered by regression tests.
Even small changes to deterministic scientific output should cause the regression suite to fail.
Establishes a versioned 1.0.0 scientific baseline for future maintenance and development.
Reduces the risk of unintended numerical changes being introduced without detection.
The reason will be displayed to describe this comment to others. Learn more.
Greater coverage of codebase by tests is a welcome addition. Do you have a feel for how the maxwindow change yesterday would have passed these had that change been made after this?
Greater coverage of codebase by tests is a welcome addition. Do you have a feel for how the maxwindow change yesterday would have passed these had that change been made after this?
Yeah I don’t think this should affect the calculation itself, as the warning was coming from MinWindowSize and MaxWindowSize being used in the constructor before they had been initialised, and the fix just changes that initialisation loop to use the fixed array size instead. I have also just done a quick check by restoring the old behaviour and running the new regression suite against it, and all 16 tests still passed, then restored the fix and they all passed again, so that gives me a bit more confidence that this change isn’t affecting the actual calculations.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR will expand the SIST scientific regression suite to cover all supported calculation modes for the 1.0.0 release.
The existing competition regression coverage has been extended with maintained baselines for melting, Z-DNA, and cruciform calculations so that future numerical drift can be detected across the supported scientific workflows.
Changes
Scientific regression baselines:
Shared SIST test execution:
Regression and CLI coverage:
P_melt,P_Z, andP_cruciformvalues across the full sequence.Impact