Skip to content

Enforce deterministic group ordering across entropy pipeline and fix ethyl-acetate regression test topology mismatch#311

Merged
harryswift01 merged 4 commits intomainfrom
310-bug-mismatch-within-regression-test
Apr 7, 2026
Merged

Enforce deterministic group ordering across entropy pipeline and fix ethyl-acetate regression test topology mismatch#311
harryswift01 merged 4 commits intomainfrom
310-bug-mismatch-within-regression-test

Conversation

@harryswift01
Copy link
Copy Markdown
Member

@harryswift01 harryswift01 commented Apr 7, 2026

Summary

This PR enforces deterministic ordering of group iteration across the entropy pipeline and fixes a configuration mismatch in the regression testing suite where the ethyl-acetate system was incorrectly using benzaldehyde topology files in the axes-off test. The changes ensure reproducible results across runs and correct topology usage, followed by regeneration of the affected baselines.

Changes

Enforce deterministic group ordering:

  • Introduced sorted(groups.items()) in all relevant nodes and workflow stages
  • Standardized iteration order over groups in configurational, orientational, vibrational, covariance, and workflow components
  • Updated group-to-index mapping to use sorted group keys for consistent indexing
  • Ensured deterministic aggregation and reporting of results

Fix topology configuration for ethyl-acetate:

  • Updated the ethyl-acetate system to reference the correct topology files
  • Removed incorrect linkage to benzaldehyde topology files in axes-off regression test

Update regression baselines:

  • Regenerated and updated baselines for the ethyl-acetate axes-off test using the corrected configuration and deterministic pipeline

Impact

  • Ensures reproducible and deterministic entropy calculations across runs
  • Prevents ordering-related nondeterminism in matrices, indexing, and outputs
  • Ensures regression tests are stable and meaningful
  • Fixes incorrect topology usage for ethyl-acetate, improving test validity and overall suite integrity

@harryswift01 harryswift01 added this to the 2.2.0 milestone Apr 7, 2026
@harryswift01 harryswift01 requested a review from skfegan April 7, 2026 12:47
@harryswift01 harryswift01 self-assigned this Apr 7, 2026
@harryswift01 harryswift01 added bug Something isn't working testing labels Apr 7, 2026
@harryswift01 harryswift01 linked an issue Apr 7, 2026 that may be closed by this pull request
@harryswift01 harryswift01 changed the title Correct topology files for ethyl-acetate axes-off regression test Enforce deterministic group ordering across entropy pipeline and fix ethyl-acetate regression test topology mismatch Apr 7, 2026
@harryswift01 harryswift01 modified the milestones: 2.2.0, 2.1.2 Apr 7, 2026
Copy link
Copy Markdown
Member

@skfegan skfegan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Tidying up the regression tests to ensure consistency.

@harryswift01 harryswift01 merged commit 192e198 into main Apr 7, 2026
23 checks passed
@harryswift01 harryswift01 deleted the 310-bug-mismatch-within-regression-test branch April 7, 2026 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working testing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Mismatch within regression testing suite config files

2 participants