Add option to individually set magento themes in Magento ApplicationTemplate #53
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tdgroot
reviewed
Nov 17, 2025
| public function setMagentoThemes(array $themes, bool $allowSplitStaticDeployment = true): void | ||
| { | ||
| $this->setVariable('magento_themes', $themes); | ||
| if (!array_is_list($themes) && $allowSplitStaticDeployment) { |
Member
There was a problem hiding this comment.
We still support 7.4 in this component. Either we bump it to >= 8.1 or we add a polyfill: symfony/polyfill-php81
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a new
setMagentoThemes()method to the Magento2 ApplicationTemplate class that allows users to individually configure Magento themes for specific locales. This enhancement provides more granular control over theme deployment when working with multi-locale setups.