Skip to content

refactor(config): extract hardcoded model defaults to constants #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Copilot wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

refactor(config): extract hardcoded model defaults to constants #33

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b8c1455
Initial plan
Copilot Dec 15, 2025
cd515c1
refactor(config): extract hardcoded model defaults to constants
Copilot Dec 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 18 additions & 4 deletions src/config.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,14 +14,28 @@
from pydantic_settings import BaseSettings


# ==================== Default Model Constants ====================
# These default values must stay in sync with env.example
# They are only used when the corresponding environment variable is not set:
# - DEFAULT_LLM_MODEL -> LLM_MODEL
# - DEFAULT_EMBEDDING_MODEL -> EMBEDDING_MODEL
# - DEFAULT_RERANK_MODEL -> RERANK_MODEL
# - DEFAULT_DS_OCR_MODEL -> DS_OCR_MODEL

DEFAULT_LLM_MODEL = "seed-1-6-250615"
DEFAULT_EMBEDDING_MODEL = "Qwen/Qwen3-Embedding-0.6B"
DEFAULT_RERANK_MODEL = "Qwen/Qwen3-Reranker-8B"
DEFAULT_DS_OCR_MODEL = "deepseek-ai/DeepSeek-OCR"


# ==================== LLM Configuration ====================

class LLMConfig(BaseSettings):
"""LLM Configuration"""

api_key: str = Field(..., description="LLM API Key")
base_url: str = Field(..., description="LLM API Base URL")
model: str = Field(default="seed-1-6-250615", description="LLM Model Name")
model: str = Field(default=DEFAULT_LLM_MODEL, description="LLM Model Name")
vlm_timeout: int = Field(default=120, description="VLM Image Understanding Timeout (seconds)")
timeout: int = Field(default=60, description="General LLM Timeout (seconds)")

Expand All @@ -44,7 +58,7 @@ class EmbeddingConfig(BaseSettings):
api_key: str = Field(..., description="Embedding API Key")
base_url: str = Field(..., description="Embedding API Base URL")
model: str = Field(
default="Qwen/Qwen3-Embedding-0.6B",
default=DEFAULT_EMBEDDING_MODEL,
description="Embedding Model Name"
)
dim: int = Field(
Expand Down Expand Up @@ -72,7 +86,7 @@ class RerankConfig(BaseSettings):
api_key: str = Field(..., description="Rerank API Key")
base_url: str = Field(..., description="Rerank API Base URL")
model: str = Field(
default="Qwen/Qwen3-Reranker-8B",
default=DEFAULT_RERANK_MODEL,
description="Rerank Model Name"
)

Expand All @@ -99,7 +113,7 @@ class DeepSeekOCRConfig(BaseSettings):
description="DeepSeek-OCR API Base URL"
)
model: str = Field(
default="deepseek-ai/DeepSeek-OCR",
default=DEFAULT_DS_OCR_MODEL,
description="DeepSeek-OCR Model Name"
)

Expand Down