Skip to content

Conversation

Copy link
Contributor

Copilot AI commented Dec 15, 2025

REDIS_URI, QDRANT_URL, and MEMGRAPH_URI are supported in src/config.py but undocumented in env.example, causing users to believe these are hardcoded Docker-internal addresses.

Changes

  • Added storage service connection URLs to env.example under "存储后端配置" section:
    • REDIS_URI - Redis/DragonflyDB connection
    • QDRANT_URL - Qdrant vector DB connection
    • MEMGRAPH_URI - Memgraph graph DB connection

Usage

# Docker internal (default)
REDIS_URI=redis://dragonflydb:6379/0

# External deployment
REDIS_URI=redis://192.168.1.100:6379/0
QDRANT_URL=http://qdrant.prod.internal:6333
MEMGRAPH_URI=bolt://memgraph.prod.internal:7687
Original prompt

This section details on the original issue you should resolve

<issue_title>Service discovery URLs hardcoded - breaks cross-environment deployment</issue_title>
<issue_description>## 问题描述
Redis/Qdrant/Memgraph 的 hostname/port 硬编码为 Docker 内部地址,导致跨环境部署失败。

受影响的文件

  • src/config.py 行 190-200

硬编码值

  • redis://dragonflydb:6379/0
  • http://qdrant:6333
  • bolt://memgraph:7687

问题

开发、测试、生产环境使用不同的存储地址时无法部署。缺失配置:REDIS_URIQDRANT_URLMEMGRAPH_URI 环境变量。

解决方案

应该从 .env 读取这些URL而不是硬编码默认值。</issue_description>

Comments on the Issue (you are @copilot in this section)


💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

…eployment

Add REDIS_URI, QDRANT_URL, and MEMGRAPH_URI to env.example so users
can configure different storage addresses for dev/test/prod environments.

Co-authored-by: BukeLy <19304666+BukeLy@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix hardcoded service discovery URLs for deployments Add storage service URLs to env.example for cross-environment deployment Dec 15, 2025
Copilot AI requested a review from BukeLy December 15, 2025 09:41
@BukeLy BukeLy requested a review from Copilot December 15, 2025 09:56
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR documents three previously undocumented storage service connection URL environment variables (REDIS_URI, QDRANT_URL, MEMGRAPH_URI) in the env.example file. These variables were already supported in src/config.py but missing from the example configuration, causing users to incorrectly assume that storage service addresses were hardcoded to Docker-internal hostnames. This documentation enables users to properly configure external storage services for cross-environment deployments (development, testing, production).

  • Adds documentation for storage service connection URLs under the "存储后端配置" section
  • Includes clear warnings about when these variables need to be configured
  • Provides examples for both Docker-internal (default) and external deployments

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@BukeLy
Copy link
Owner

BukeLy commented Dec 15, 2025

@copilot implement #25 (review)

Copy link
Contributor Author

Copilot AI commented Dec 15, 2025

@copilot implement #25 (review)

Review #3577353134 is an auto-generated PR overview summary, not a request for changes. It confirms the PR correctly:

  • Documents REDIS_URI, QDRANT_URL, MEMGRAPH_URI in env.example
  • Includes warnings about cross-environment configuration
  • Provides usage examples for Docker and external deployments

The PR is complete as-is. If you have specific changes you'd like me to make, please let me know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Service discovery URLs hardcoded - breaks cross-environment deployment

2 participants