fix: publish custom event polyfill - #4777
Conversation
🦋 Changeset detectedLatest commit: 726f9c6 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
| Command | Status | Duration | Result |
|---|---|---|---|
nx test @snippet/react |
❌ Failed | 5m 27s | View ↗ |
nx test @e2e/qwik-city |
✅ Succeeded | 10m 4s | View ↗ |
nx test @e2e/nextjs-sdk-next-app |
✅ Succeeded | 9m 38s | View ↗ |
nx test @e2e/angular-17 |
✅ Succeeded | 9m 3s | View ↗ |
nx test @e2e/react-sdk-next-15-app |
✅ Succeeded | 7m 39s | View ↗ |
nx test @e2e/nuxt |
✅ Succeeded | 5m 17s | View ↗ |
nx test @e2e/hydrogen |
✅ Succeeded | 7m 17s | View ↗ |
nx test @e2e/angular-17-ssr |
✅ Succeeded | 7m 43s | View ↗ |
Additional runs (37) |
✅ Succeeded | ... | View ↗ |
💡 Dealing with memory or CPU issues? See memory and CPU details with the resource usage add-on ↗.
☁️ Nx Cloud last updated this comment at 2026-08-04 20:45:02 UTC
|
Review Agent skipped this PR — @davilima6 doesn't have a Builder seat in this space. If you're @davilima6: you may already have a seat under a different GitHub account. Reconnect GitHub If you're an admin: Add @davilima6 to this space |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |

Purpose
Ensure the custom event polyfill referenced by the SDK's generated declarations is included in the published package.
Approach and changes
builder.class.d.tswindow.CustomEventwhen it is missingTesting instructions
yarn workspace @builder.io/sdk buildpackages/core/dist/src/polyfills/custom-event-polyfill.jsandpackages/core/dist/src/polyfills/custom-event-polyfill.d.tsexistnoUncheckedSideEffectImports, import@builder.io/sdkand runtsc --noEmit. The declaration import of./polyfills/custom-event-polyfillshould resolveNote
Low Risk
Small packaging and typing fix for an existing browser polyfill with no auth, data, or API behavior changes.
Overview
Fixes a published package gap where
builder.class.d.tsside-effect-imports./polyfills/custom-event-polyfill, but consumers runningtsc --noEmit(especially with strict side-effect import checks) could not resolve that module.The polyfill is now TypeScript so the SDK build emits
custom-event-polyfill.jsand a matching.d.tsnext to the generated declarations. Runtime behavior is unchanged: the IIFE still only patcheswindow.CustomEventwhen it is missing in the browser.Reviewed by Cursor Bugbot for commit 726f9c6. Bugbot is set up for automated code reviews on this repo. Configure here.