Skip to content

fix(design): persist pointer-driven layer reorders - #5523

Merged
steve8708 merged 2 commits into
mainfrom
fix/design-layers-drag-persistence
Sep 21, 2026
Merged

steve8708 merged 2 commits into
mainfrom
fix/design-layers-drag-persistence

Conversation

@steve8708

Copy link
Copy Markdown
Contributor

Fixes Layers-panel reorder drops that arrive with an empty dataTransfer payload during pointer-driven Chromium drags.

  • fall back to the authoritative same-window drag state
  • exercise the reorder with Playwright pointer events
  • verify the reordered layers survive reload

Validation: git diff --check passed. Focused runtime tests could not run because workspace dependencies are not installed.

builder-io-integration[bot]

This comment was marked as outdated.

@github-actions

github-actions Bot commented Sep 21, 2026

Copy link
Copy Markdown
Contributor

Here's a visual recap of what changed:

Visual recap

Open the full interactive recap

builder-io-integration[bot]

This comment was marked as outdated.

builder-io-integration[bot]

This comment was marked as outdated.

@steve8708
steve8708 force-pushed the fix/design-layers-drag-persistence branch from 66fea9a to b27240b Compare September 21, 2026 21:43
@steve8708
steve8708 force-pushed the fix/design-layers-drag-persistence branch from b27240b to f817588 Compare September 21, 2026 21:44
builder-io-integration[bot]

This comment was marked as outdated.

@github-actions
github-actions Bot temporarily deployed to pr-5523-design September 21, 2026 23:03 Destroyed

@builder-io-integration builder-io-integration Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Builder reviewed your changes — looks good ✅

Review Details

Incremental Code Review — Previous Comment Resolved

The latest commit changes the helper declarations to non-exported declarations with explicit value/type re-exports:

  • canUseActiveDragStateForDrop remains a named runtime export
  • LayersPanelMoveIntent remains a type-only export
  • The new Vitest import remains valid
  • No application behavior or drag/drop logic changed

Two independent review agents found no confirmed regressions. One verified the new test import and another verified the explicit exports preserve the module API; direct TypeScript validation was also reported as successful.

The previously open comment requesting these exports has been verified fixed and resolved.

Risk: Standard; this is a module-export/testability adjustment with no runtime behavior change.

🧪 Browser testing: Skipped — the dev server was unavailable while workspace setup was still installing dependencies. The change is export-only and does not alter user-facing behavior.

@steve8708
steve8708 merged commit e61b15a into main Sep 21, 2026
44 of 45 checks passed
@steve8708
steve8708 deleted the fix/design-layers-drag-persistence branch September 21, 2026 23:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant