Skip to content

build(deps): bump @brightsec/node-libcurl to 5.1.6 - #790

Merged
derevnjuk merged 2 commits into
nextfrom
chore/sec-bump-node-libcurl
Oct 7, 2026
Merged

derevnjuk merged 2 commits into
nextfrom
chore/sec-bump-node-libcurl

Conversation

@aborovsky

@aborovsky aborovsky commented Oct 5, 2026 •

Copy link
Copy Markdown
Contributor

No description provided.

@aborovsky aborovsky self-assigned this Oct 6, 2026
@aborovsky

aborovsky commented Oct 6, 2026 •

Copy link
Copy Markdown
Contributor Author

Bumps @brightsec/node-libcurl 5.1.3 → 5.1.6, keeping bright-cli on the
maintained node-libcurl release.

Upstream: BrightSec/node-libcurl#46 (released as @brightsec/node-libcurl@5.1.6).

Change

  • @brightsec/node-libcurl → 5.1.6 (package.json + lockfile)

That is the only change in this PR after rebasing onto next.

Why 5.1.6

5.1.6 makes node-libcurl's Windows vcpkg source build resilient to GNU FTP
outages. Some vcpkg ports (notably gsasl) download their sources only from
ftpmirror.gnu.org / ftp.gnu.org; when that network is unreachable the
install fails with Download timed out … halting portfile. 5.1.6 routes vcpkg
asset downloads through an x-script provider that falls back to a reachable
GNU mirror (mirrors.kernel.org) and still verifies each asset's SHA512, so the
download no longer depends on GNU FTP being up.

Relationship to #788 (already merged)

The transitive build-toolchain deps this PR originally also refreshed —
tar → 7.5.22, brace-expansion → 1.1.21 / 2.1.7 (incl. the
@brightsec/node-libcurl subtree copy), picomatch → 4.0.7 — have already
landed on next
via the merged undici-override PR (#788), which refreshed the
lockfile. So those updates are no longer part of this diff; next and this
branch already carry the patched versions.

This PR is therefore the clean follow-up that moves the direct dependency itself
onto 5.1.6 (the upstream release that fixed its own lockfile and added the
GNU-mirror install resilience), so bright-cli no longer pins the superseded
5.1.3.

Security note

Verification

  • Rebased onto current next; diff is @brightsec/node-libcurl 5.1.3 → 5.1.6
    only (package.json + the two lockfile entries).
  • node-libcurl resolves from the public npm registry; no npm.pkg.github.com
    URLs in the lockfile.
  • npm ci succeeds with a token-less public-npm config.
  • npm run build (webpack, production) succeeds.
  • npm run test:unit → 222 passed. (The one native-addon resolution error
    seen locally is from installing with --ignore-scripts, i.e. no prebuilt
    @brightsec/node-libcurl binary — not a regression; CI installs it normally.)
  • E2E ci job run succeeded

@aborovsky aborovsky added the dependencies Pull requests that update a dependency file label Oct 6, 2026
@aborovsky
aborovsky force-pushed the chore/sec-bump-node-libcurl branch from 29834de to 8aaeda6 Compare October 6, 2026 10:39
@derevnjuk

derevnjuk commented Oct 6, 2026 •

Copy link
Copy Markdown
Member

build not fix #793 (comment)

@aborovsky

Copy link
Copy Markdown
Contributor Author

build not fix #793 (comment)

Then it won't trigger patch release. Which is a problem.

@brightsec/node-libcurl 5.1.6 (BrightSec/node-libcurl#46) makes the Windows
vcpkg source build resilient to GNU FTP outages: it routes vcpkg asset
downloads through an x-script that falls back to a reachable GNU mirror
(gsasl etc.), fixing the download timeouts that broke the Windows e2e install.

Keeps bright-cli on the maintained node-libcurl release. The transitive build
deps (tar / brace-expansion / picomatch) were already patched on next via the
undici-override PR (#788); this bump moves the direct dependency itself and
carries the install-resilience fix.

Production webpack build and all 222 unit tests pass.
@aborovsky
aborovsky force-pushed the chore/sec-bump-node-libcurl branch from 8aaeda6 to e24ca37 Compare October 6, 2026 21:29
@aborovsky aborovsky changed the title fix(deps): bump @brightsec/node-libcurl to 5.1.4 and patch transitive build deps fix(deps): bump @brightsec/node-libcurl to 5.1.6 Oct 6, 2026
@aborovsky
aborovsky marked this pull request as ready for review October 7, 2026 04:27
@aborovsky
aborovsky enabled auto-merge (squash) October 7, 2026 04:28
@derevnjuk

derevnjuk commented Oct 7, 2026 •

Copy link
Copy Markdown
Member

build not fix #793 (comment)

Then it won't trigger patch release. Which is a problem.

@aborovsky your assumption isn't correct: https://github.com/NeuraLegion/bright-cli/blob/6fd1f76d9d835f784425e99edd16ba2765959328/.releaserc#L9

e.g. eeda38d

@derevnjuk
derevnjuk disabled auto-merge October 7, 2026 07:40
@aborovsky aborovsky changed the title fix(deps): bump @brightsec/node-libcurl to 5.1.6 build(deps): bump @brightsec/node-libcurl to 5.1.6 Oct 7, 2026
@derevnjuk
derevnjuk enabled auto-merge (squash) October 7, 2026 07:53
@derevnjuk
derevnjuk merged commit 94548f4 into next Oct 7, 2026
11 checks passed
@derevnjuk
derevnjuk deleted the chore/sec-bump-node-libcurl branch October 7, 2026 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants