sp_BlitzIndex: Added an ORDER BY to the temporal table check #3728
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A one-line PR!
Closes #3727. Let the screenshots speak for themselves.
Before
After
I couldn't be bothered to make my own database packed full of temporal tables, so I put my faith in Microsoft and loaded up this copy of WideWorldImporters. Once you have that loaded, just run
EXEC sp_BlitzIndex @Databasename = 'WideWorldImporters', @Mode = 4;and you will see the difference.I unfortunately couldn't use the fix I preferred in the issue. The second part of the
ORDER BYin the final output sorts by the auto-increment ID columnbr.check_id. I couldn't overcome that sort without making bigger changes. On the bright side, thecheck_idthing is what made this a one-line PR.