Skip to content

Fix save-html --no-images ignoring -o - #583

Open
vishal-tambi wants to merge 3 commits into
Breakthrough:mainfrom
vishal-tambi:fix/save-html-test-output
Open

vishal-tambi wants to merge 3 commits into
Breakthrough:mainfrom
vishal-tambi:fix/save-html-test-output

Conversation

@vishal-tambi

@vishal-tambi vishal-tambi commented Oct 18, 2026 •

Copy link
Copy Markdown

save-html --no-images ignored the global -o and wrote the HTML to the working directory, which is why test_cli_save_html left goldeneye-Scenes.html in the repo root. CliContext.save_images_result started as (None, None) instead of None, so save_html took its output folder from a save-images run that never happened. It now starts as None, and the test checks that the file lands in the -o folder.

@Breakthrough Breakthrough left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

with --no-images, save-html ignores -o. CliContext.save_images_result starts as (None, None) instead of None, so save_html takes its output folder from a save-images run that never happened. I can fix that in a separate PR if you'd like.

Thanks for kicking this off. We should change that behaviour to fix this properly here. By -o do you mean the global or local directory option (or both)?

@vishal-tambi

Copy link
Copy Markdown
Author

Just the global -o, since save-html doesn't have a local one. Fixed it here: save_images_result now starts as None, so --no-images writes to -o, and the test checks that.

@vishal-tambi vishal-tambi changed the title Stop test_cli_save_html from writing into the repo root Fix save-html --no-images ignoring -o Oct 20, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants