Repository navigation
Fix save-html --no-images ignoring -o - #583
Open
vishal-tambi wants to merge 3 commits into
Open
vishal-tambi wants to merge 3 commits into
vishal-tambi wants to merge 3 commits into
Conversation
Breakthrough
requested changes
Oct 20, 2026
Breakthrough
left a comment
Owner
There was a problem hiding this comment.
with --no-images, save-html ignores -o. CliContext.save_images_result starts as (None, None) instead of None, so save_html takes its output folder from a save-images run that never happened. I can fix that in a separate PR if you'd like.
Thanks for kicking this off. We should change that behaviour to fix this properly here. By -o do you mean the global or local directory option (or both)?
Author
|
Just the global |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
save-html --no-imagesignored the global-oand wrote the HTML to the working directory, which is whytest_cli_save_htmlleftgoldeneye-Scenes.htmlin the repo root.CliContext.save_images_resultstarted as(None, None)instead ofNone, sosave_htmltook its output folder from asave-imagesrun that never happened. It now starts asNone, and the test checks that the file lands in the-ofolder.