Accept a path or file handle in write_scene_list - #566
Open
jennifferweslowski-design wants to merge 2 commits into
Open
Accept a path or file handle in write_scene_list#566jennifferweslowski-design wants to merge 2 commits into
jennifferweslowski-design wants to merge 2 commits into
Conversation
Open path arguments with a context manager so the file is closed after writing. Existing file-handle callers are unchanged.
Breakthrough
approved these changes
Aug 15, 2026
Breakthrough
approved these changes
Aug 16, 2026
Breakthrough
left a comment
Breakthrough
left a comment
Owner
There was a problem hiding this comment.
Needs formatting w/ ruff but LGTM otherwise! 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #523
write_scene_list("scenes.csv", scenes)currently raisesTypeError: argument 1 must have a "write" methodbecause the path string is passed straight tocsv.writer.This change lets the first argument be a file handle (existing callers) or a
str/pathlib.Path. A path is opened withnewline=""inside a context manager so the file is closed after writing, which matches the concern on the issue.Tests cover a
StringIOhandle, astrpath, and aPath. No video fixtures.I could not run the suite in this environment; the new tests follow the existing
_fake_scenespattern intests/test_output.py.