feat: ARIA Roles & Properties für CookiePolicy implementiert (#144) #463
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ap-Academy#144) - Dialog mit role="dialog", aria-modal, aria-labelledby, aria-describedby - ARIA-IDs für Titel und Beschreibung gesetzt - Fokus-Falle via Tab getestet - Unit-Tests für Anzeige, Interaktion und Cookie-Handling - E2E-Test mit Playwright: Fokus, Klick, Reload, Route-Ausnahme
… limit Vitest to unit tests
… limit Vitest to unit tests
…t mocks, and resolved ESM/CJS conflict by renaming eslint.config.js to eslint.config.cjs.
…rap and corresponding E2E tests.
|
Preview deployed to https://0079028b.academy-preview.pages.dev (total size: 15M) |
Author
|
@<TheMorpheus407/Reviewer> This PR is now ready for final review and merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implements ARIA roles and properties for the CookiePolicy component to improve accessibility and keyboard usability.
Includes tests for expected behavior and edge cases as described in ticket #144.
Type of change
Note on commit history
The long list of commits was cleaned up by the last two commits:
chore: Fix test and lint setup...: Bundles all necessary corrections to the test environment (dependencies, CJS/ESM conflict, mock corrections) that were needed to restore pipeline functionality.feat(a11y): Implement accessible...: Contains only the pure feature code.All tests (unit/E2E/lint) are now green on the CI server.
Fixes Bootstrap-Academy/Bootstrap-Academy#144
My Bootstrap Academy username: PeachpitRipley