Skip to content

ENH: Factor out the 6-face neighbor code that is systemic through out the code base.#1523

Merged
imikejackson merged 1 commit intoBlueQuartzSoftware:developfrom
imikejackson:topic/face_neighbor_algorithm_updates
Feb 5, 2026
Merged

ENH: Factor out the 6-face neighbor code that is systemic through out the code base.#1523
imikejackson merged 1 commit intoBlueQuartzSoftware:developfrom
imikejackson:topic/face_neighbor_algorithm_updates

Conversation

@imikejackson
Copy link
Contributor

@imikejackson imikejackson commented Feb 4, 2026

This utility file has common functions for dealing with the 6-face neighbor algorithm that is used throughout simplnx.

Plugins that are updated

SimplnxCore Plugin

Compatible Completed Tested File Notes
[ ] [ ] [ ] RequireMinimumSizeFeatures.cpp Another PR fixes this
[x] [x] [ ] RequireMinNumNeighbors.cpp
[x] [x] [ ] RemoveFlaggedFeatures.cpp
[x] [x] [ ] ErodeDilateCoordinationNumber.cpp
[x] [x] [ ] ErodeDilateBadData.cpp
[x] [x] [ ] ErodeDilateMask.cpp Only 1 of the 2 face-neighbor loops
[x] [x] [ ] FillBadData.cpp
[x] [x] [ ] ComputeBoundaryCells.cpp Line 84 start
[x] [x] [ ] ComputeEuclideanDistMap.cpp Line 343 start
[ ] [ ] [ ] ReplaceElementAttributesWithNeighborValues.cpp Does not fall into this code schema. Skip File
[ ] [ ] [ ] ComputeFeatureNeighborsFilter.cpp Does not fall into this code schema. Skip

OrientationAnalysis Plugin

Compatible Completed Tested File Notes
[x] [x] [ ] BadDataNeighborOrientationCheck.cpp Start on line 99
[x] [x] [ ] NeighborOrientationCorrelation.cpp Start line 233

@imikejackson imikejackson requested a review from nyoungbq February 4, 2026 23:35
@imikejackson imikejackson enabled auto-merge (squash) February 4, 2026 23:36
@imikejackson imikejackson force-pushed the topic/face_neighbor_algorithm_updates branch from 87d2298 to 317df1b Compare February 5, 2026 00:10
Copy link
Contributor

@nyoungbq nyoungbq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Found one place in the supplied files that was missed. This definitely improves the readability of the whole thing.

@imikejackson imikejackson force-pushed the topic/face_neighbor_algorithm_updates branch 2 times, most recently from 0e36210 to 2ba45ba Compare February 5, 2026 13:16
@imikejackson imikejackson requested a review from nyoungbq February 5, 2026 13:17
@imikejackson imikejackson force-pushed the topic/face_neighbor_algorithm_updates branch from 2ba45ba to 70209be Compare February 5, 2026 14:58
This utility file has common functions for dealing with the 6 face neighbor algorithm that is used through out simplnx.
@imikejackson imikejackson force-pushed the topic/face_neighbor_algorithm_updates branch from 70209be to 383ca02 Compare February 5, 2026 15:29
@imikejackson imikejackson merged commit 9bfcb01 into BlueQuartzSoftware:develop Feb 5, 2026
6 checks passed
@imikejackson imikejackson deleted the topic/face_neighbor_algorithm_updates branch February 5, 2026 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants