ENH: Factor out the 6-face neighbor code that is systemic through out the code base.#1523
Merged
imikejackson merged 1 commit intoBlueQuartzSoftware:developfrom Feb 5, 2026
Conversation
87d2298 to
317df1b
Compare
nyoungbq
reviewed
Feb 5, 2026
Contributor
nyoungbq
left a comment
There was a problem hiding this comment.
Looks great! Found one place in the supplied files that was missed. This definitely improves the readability of the whole thing.
src/Plugins/SimplnxCore/src/SimplnxCore/Filters/Algorithms/ErodeDilateCoordinationNumber.cpp
Outdated
Show resolved
Hide resolved
0e36210 to
2ba45ba
Compare
nyoungbq
approved these changes
Feb 5, 2026
2ba45ba to
70209be
Compare
This utility file has common functions for dealing with the 6 face neighbor algorithm that is used through out simplnx.
70209be to
383ca02
Compare
nyoungbq
approved these changes
Feb 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This utility file has common functions for dealing with the 6-face neighbor algorithm that is used throughout simplnx.
Plugins that are updated
SimplnxCore Plugin
OrientationAnalysis Plugin