BUG: Fix int32 overflow bug and code refactoring in Require Minimum Feature Size#1522
Merged
imikejackson merged 6 commits intoBlueQuartzSoftware:developfrom Feb 5, 2026
Conversation
nyoungbq
reviewed
Feb 4, 2026
src/Plugins/SimplnxCore/src/SimplnxCore/Filters/Algorithms/RequireMinimumSizeFeatures.cpp
Outdated
Show resolved
Hide resolved
src/Plugins/SimplnxCore/src/SimplnxCore/Filters/Algorithms/RequireMinimumSizeFeatures.cpp
Outdated
Show resolved
Hide resolved
src/Plugins/SimplnxCore/src/SimplnxCore/Filters/Algorithms/RequireMinimumSizeFeatures.cpp
Outdated
Show resolved
Hide resolved
imikejackson
force-pushed
the
topic/require_min_size_features
branch
6 times, most recently
from
82735f2 to
c9cb350
Compare
nyoungbq
approved these changes
Feb 5, 2026
imikejackson
force-pushed
the
topic/require_min_size_features
branch
from
35907b7 to
0a06c9e
Compare
This commit also updates a good portion of the algorithm and places it into the algorithm file.
imikejackson
force-pushed
the
topic/require_min_size_features
branch
from
65db2e5 to
86ab3a5
Compare
imikejackson
force-pushed
the
topic/require_min_size_features
branch
from
86ab3a5 to
8353365
Compare
imikejackson
force-pushed
the
topic/require_min_size_features
branch
from
8353365 to
5f6b8a2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Due to casting there could be an int32 overflow issue that occurs during the running of this filter.
The filter was also heavily refactored in the process: