[WIP] ENH: H5 Readers - Allow Separate Scans from Single File#1130
Draft
nyoungbq wants to merge 9 commits intoBlueQuartzSoftware:developfrom
Draft
[WIP] ENH: H5 Readers - Allow Separate Scans from Single File#1130nyoungbq wants to merge 9 commits intoBlueQuartzSoftware:developfrom
nyoungbq wants to merge 9 commits intoBlueQuartzSoftware:developfrom
Conversation
Open
3 tasks
203e3f7 to
79919f8
Compare
79919f8 to
357dc91
Compare
648c430 to
31d8d72
Compare
653d1b7 to
60b2f45
Compare
- Correct human name for combing scans parameter - put oweness on subclass to define the update origin (case by case problem) - add nullptr checks and Error messaging
60b2f45 to
cb5e92c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes:
#510
!!! Open-Source Data Needed For Test Cases !!!
Naming Conventions
Naming of variables should descriptive where needed. Loop Control Variables can use
iif warranted. Most of these conventions are enforced through the clang-tidy and clang-format configuration files. See the filesimplnx/docs/Code_Style_Guide.mdfor a more in depth explanation.Filter Checklist
The help file
simplnx/docs/Porting_Filters.mdhas documentation to help you port or write new filters. At the top is a nice checklist of items that should be noted when porting a filter.Unit Testing
The idea of unit testing is to test the filter for proper execution and error handling. How many variations on a unit test each filter needs is entirely dependent on what the filter is doing. Generally, the variations can fall into a few categories:
Code Cleanup