This repository was archived by the owner on Feb 26, 2025. It is now read-only.
check if .asc files as input#24
Merged
lidakanari merged 9 commits intoBlueBrain:masterfrom Jan 23, 2020
arnaudon:master
Merged
Conversation
lidakanari
suggested changes
Jan 17, 2020
Collaborator
lidakanari
left a comment
lidakanari
left a comment
There was a problem hiding this comment.
Please add back the "tree_type_finals"
Collaborator
Author
|
sorry about the conflict versions, it should be back now |
lidakanari
reviewed
Jan 17, 2020
Collaborator
|
It looks like something is wrong with Travis and the checks don't run. @wizmer could you help fix this? |
Contributor
|
I have no idea. @arnaudon Could you try adding a commit to see if this was a fluke ? |
Collaborator
|
It is the same for other PR (#25) so I assume this is a more general issue. |
Collaborator
Author
|
Just got my account to be part of BlueBrain, and did a new push on my fork. It seems that it still does not work... |
Collaborator
|
@arnaudon Have you ever logged into https://travis-ci.org? |
Collaborator
Author
|
So my travis account was flagged for potential abuse, and after being unflagged, the build could be run, so feel free to merge! |
lidakanari
approved these changes
Jan 23, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Had the classic issue of inputing .asc files instead of .h5 or .swc, so added a line to raise an exception if some .asc files are givenb to TMD to generate distribution and parameters.