Skip to content

Bound did:key decoding by canonical encoded length - #6

Merged
gerau merged 1 commit into
masterfrom
feature/wallet-session-core-didkey
Nov 3, 2026
Merged

gerau merged 1 commit into
masterfrom
feature/wallet-session-core-didkey

Conversation

@KyrylR

@KyrylR KyrylR commented Oct 28, 2026

Copy link
Copy Markdown
Collaborator

Reject oversized issuers before quadratic base58 decoding. Keep valid Ed25519 identifiers and supported same-length key type handling intact.

@KyrylR
KyrylR requested a review from gerau October 28, 2026 11:13

@gerau gerau left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 09c4929; code review

Reject oversized issuers before quadratic base58 decoding. Keep valid Ed25519 identifiers and supported same-length key type handling intact.
@KyrylR
KyrylR force-pushed the feature/wallet-session-core-didkey branch from 09c4929 to 00ba547 Compare November 2, 2026 11:37

@gerau gerau left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 00ba547

@gerau
gerau merged commit 9bfc172 into master Nov 3, 2026
2 checks passed
@gerau
gerau deleted the feature/wallet-session-core-didkey branch November 3, 2026 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants