Move testing to nextest by ikripaka · Pull Request #75 · BlockstreamResearch/smplx

ikripaka · 2026-05-12T09:12:13Z

This PR suggests a bug fix and I've added the necessary tests.
This PR introduces a new feature and I've discussed the update in an Issue or with the team.
This PR is just a minor change like a typo fix.

migrate existing interface to nextest testing framework https://nexte.st
update simplexup to install nextest by default
add nextest dependency as a standalone binary, which is installed via simplexup
add cargo-binstall dependency for cargo-nextest binary installation

fix simplexup version check commands

…installation * edit simplexup to install local binary version * add one more verbosity level for additional cargo verbosity * fix todo for const variable

…command

* rename --nocapture to --no-capture

Arvolear

Will ask Oleh to take a look and if he is ok, will approve and merge this.

add no-capture to -v and -vv options

* add downloading and packing of cargo-nextest into attested zip * adapt simplexup

* edit quiet flag description

… shutdown

Arvolear · 2026-05-29T12:46:11Z

-    /// Show grouped output after the test completion
+    /// Show detailed output about running tests
    #[arg(long = "show-output")]
    pub show_output: bool,


Do we need this if we have -v now?

Yep, I moved the "--verbose" flag from nextest there
It just gives very verbose info about commands that are executed via tests
It isn't connected to "no-capture", but just gives additional info

smplx/crates/cli/src/commands/test.rs

Line 108 in 1945d11

test_bin_args.push("--show-output".into());

Arvolear · 2026-05-29T12:55:02Z


-        if flags.no_fail_fast {
-            cargo_test_args.push("--no-fail-fast".into());
+        // `--test-threads` flag is ignored by nextest when `--no-capture` is enabled


And what does it do? Does it default to 1?

Yes, because enabling threads along with no-capture would turn the output into a mess of logs.
Nextest throws a warning and disables it by default, so I added this if statement to suppress the warning.

Arvolear · 2026-05-29T12:56:29Z

-        if flags.no_fail_fast {
-            cargo_test_args.push("--no-fail-fast".into());
+        // `--test-threads` flag is ignored by nextest when `--no-capture` is enabled
+        if flags.verbose == 0 {


Why are you putting this if here, where there is a separate function designed exactly to handle the flags?

Arvolear · 2026-05-29T12:59:03Z

    /// Panics if setting the Ctrl-C handler fails, or if required RPC authentication credentials cannot be unwrapped.
    pub fn run(config: &RegtestConfig) -> Result<(), CommandError> {
-        let (mut client, signer) = RegtestRunner::from_config(config)?;
+        let (client, signer) = RegtestRunner::from_config(config)?;


Suggested change

let (client, signer) = RegtestRunner::from_config(config)?;

// The client will be killed automatically via the Drop trait implementation

let (client, signer) = RegtestRunner::from_config(config)?;

Arvolear · 2026-05-29T13:01:30Z

 mnemonic = "exist carry drive collect lend cereal occur much tiger just involve mean"
 bitcoins = 10_000_000
-verbosity = 0 # 0 - none, 1 - debug, 2 - trace
+verbosity = 0 # 0 - none, 1 - debug, 2 - trace, 3 - trace + additional cargo verbose output


Please check that everything else is up to date.

Suggested change

verbosity = 0 # 0 - none, 1 - debug, 2 - trace, 3 - trace + additional cargo verbose output

verbosity = 0 # 0 - none, 1 - debug, 2 - trace

Yeah, I searched for it, but I couldn't find it

Arvolear · 2026-05-29T13:02:21Z

 main() {
  need_cmd git
  need_cmd curl
+  need_cmd cargo


Do we still need it?

I'll move it to the install_simplex_from_commit function. It's required there.

ikripaka self-assigned this May 12, 2026

ikripaka force-pushed the feat/nextest branch from eb4ea14 to ea7a845 Compare May 12, 2026 09:20

Base automatically changed from dev to master May 12, 2026 19:06

ikripaka force-pushed the feat/nextest branch from 1b89fc0 to 4ea228c Compare May 13, 2026 07:58

Arvolear changed the base branch from master to dev May 13, 2026 15:52

ikripaka force-pushed the feat/nextest branch 2 times, most recently from 4e9006f to c60bc81 Compare May 14, 2026 05:43

ikripaka marked this pull request as ready for review May 14, 2026 07:18

ikripaka requested a review from Arvolear as a code owner May 14, 2026 07:18

ikripaka added 3 commits May 18, 2026 11:20

simplexup: add cargo-nextest installation

10d77e2

cli: migrate from cargo test to cargo nextest

8eabcb9

cli: add formal nextest version check

681de64

fix simplexup version check commands

ikripaka force-pushed the feat/nextest branch from eee805e to 681de64 Compare May 18, 2026 10:13

cli: change dependency from cargo nextest to local smplx-nextest …

78dc70c

…installation * edit simplexup to install local binary version * add one more verbosity level for additional cargo verbosity * fix todo for const variable

ikripaka force-pushed the feat/nextest branch from 7dc7f91 to 78dc70c Compare May 18, 2026 15:39

Arvolear reviewed May 19, 2026

View reviewed changes

Comment thread crates/cli/src/commands/test.rs Outdated

Arvolear reviewed May 19, 2026

View reviewed changes

Comment thread crates/test/src/config.rs Outdated

Arvolear reviewed May 19, 2026

View reviewed changes

Comment thread simplexup/simplexup Outdated

Arvolear reviewed May 19, 2026

View reviewed changes

Comment thread crates/cli/src/commands/test.rs

ikripaka added 2 commits May 19, 2026 16:31

cli: edit namings in commands/test.rs for building smplx-nextest …

e2a0a63

…command

remove leftover semver check arguments

5c3dddb

Arvolear reviewed May 20, 2026

View reviewed changes

Comment thread crates/cli/src/commands/test.rs

Arvolear reviewed May 20, 2026

View reviewed changes

Comment thread simplexup/simplexup Outdated

Arvolear reviewed May 20, 2026

View reviewed changes

Comment thread simplexup/simplexup Outdated

Arvolear reviewed May 20, 2026

View reviewed changes

Comment thread simplexup/simplexup Outdated

ikripaka added 3 commits May 21, 2026 10:47

cli: move forming of flags to separate function

4b8d1c2

simplexup: add newlines

61175dd

simplexup: simplify version retrieval for comparison

05add01

Arvolear reviewed May 21, 2026

View reviewed changes

Comment thread crates/cli/src/commands/test.rs Outdated

cli: move bin args building to one function

5c61739

simplexup: remove cargo-binstall

ee104a4

Arvolear reviewed May 25, 2026

View reviewed changes

Comment thread crates/cli/src/commands/test.rs Outdated

cli: add nextest dsl test maker enabled by default

c061e4f

ikripaka force-pushed the feat/nextest branch from 39a45e2 to 23a50d9 Compare May 26, 2026 12:52

cli: add --no-simplex flag

e2ff677

* rename --nocapture to --no-capture

ikripaka force-pushed the feat/nextest branch from 23a50d9 to e2ff677 Compare May 26, 2026 15:20

cli: add alias (nocapture) for no-capture flag in tests

174b469

Arvolear reviewed May 27, 2026

View reviewed changes

Comment thread crates/cli/src/commands/core.rs Outdated

Update crates/cli/src/commands/core.rs

e280921

Arvolear reviewed May 28, 2026

View reviewed changes

Comment thread crates/cli/src/commands/test.rs Outdated

Arvolear reviewed May 28, 2026

View reviewed changes

Comment thread simplexup/simplexup Outdated

ikripaka added 2 commits May 28, 2026 17:42

cli: remove -vvv option

473a49e

add no-capture to -v and -vv options

simplexup: remove cargo install dependency

2209a5b

* add downloading and packing of cargo-nextest into attested zip * adapt simplexup

ikripaka force-pushed the feat/nextest branch from 71e9bbc to 2209a5b Compare May 28, 2026 15:46

ikripaka added 8 commits May 28, 2026 19:51

cli: add test-threads flag

8b49076

ci: add smplx-nextest binaries name to zip packing and attestation

bf05e35

ci: fix verbosity in fixtures.yml

921b0de

cli: divide verbose flag into 2

cbefe0a

* edit quiet flag description

cli: add test-threads flag ignoring when no-capture set

3b1ee7d

cli: limit test-threads flag to non-zero values

43d7381

cli: add drop contexts, so memory can be gracefully cleaned on normal…

d147feb

… shutdown

cli: correct show_output description

7fdea36

Arvolear reviewed May 29, 2026

View reviewed changes

fix lints

f030606

	let (client, signer) = RegtestRunner::from_config(config)?;
	// The client will be killed automatically via the Drop trait implementation
	let (client, signer) = RegtestRunner::from_config(config)?;

	verbosity = 0 # 0 - none, 1 - debug, 2 - trace, 3 - trace + additional cargo verbose output
	verbosity = 0 # 0 - none, 1 - debug, 2 - trace

Conversation

ikripaka commented May 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Arvolear left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Arvolear May 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

ikripaka commented May 12, 2026 •

edited

Loading

Arvolear May 29, 2026 •

edited

Loading