fix: Correct FullMultiply signatures and tracker argument decoding#274
Open
metalurgical wants to merge 1 commit intoBlockstreamResearch:masterfrom
Open
fix: Correct FullMultiply signatures and tracker argument decoding#274metalurgical wants to merge 1 commit intoBlockstreamResearch:masterfrom
metalurgical wants to merge 1 commit intoBlockstreamResearch:masterfrom
Conversation
Fix incorrect signatures for FullMultiply. Additionally fixes a bug in tracker, which was surfaced by this fix so that it correctly decodes inputs. Changes: - FullMultiply((A,B),(C,D)) signatures corrected to FullMultiply(A,B,C,D) - Fix argument parsing in tracker by utilizing Unfolder - Removes `collect_product_elements` helper. - Adds regression test covering FullMultiply functions Furthermore, this keeps the semantics unchanged ((A*B) + C + D) while fixing the API surface and ensuring tracker compatibility.
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix incorrect signatures for FullMultiply. Additionally fixes a bug in tracker, which was surfaced by this fix, so that it correctly decodes inputs.
Changes:
collect_product_elementshelper.Furthermore, this keeps the semantics unchanged ((A*B) + C + D) while fixing the API surface and ensuring tracker compatibility.