Merge persisted updates if greater than given thresholds#137
Merged
Merge persisted updates if greater than given thresholds#137
Conversation
jackstar12
reviewed
Feb 21, 2026
|
|
||
| // Expected final state: Balance 899,974, Transactions: 2, UTXOs: 1 | ||
| assert_eq!( | ||
| btc_balance, 899_974, |
Contributor
There was a problem hiding this comment.
Lets not hardcode this balance value but get it from the wollet itself before we merge
Contributor
Author
There was a problem hiding this comment.
This is coming from hardcoded test vectors, so it's fine to use an hardcoded value.
I am adding also integration testing...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some users lament low startup time for big wallets, they say most of the time is passed loading multiple stored updates.
This change allow to specify a merge-threshold which triggers the merging of the stored updates into 1