feat: add Franklin Desktop download link - #23
Conversation
VickyXAI
left a comment
VickyXAI
left a comment
There was a problem hiding this comment.
Pre-landing review — 1 blocker, 5 informational
🔴 Blocker
src/components/Header.tsx:10 — the download link 404s for every visitor. DESKTOP_RELEASES_URL points to github.com/BlockRunAI/franklin-desktop/releases/latest, but that repo is currently private — anonymous visitors get a GitHub 404. The v0.1.2 release itself is ready (macOS arm64 .dmg + Windows .exe), so this resolves once the repo goes public, but until then this ships a prominent gold nav CTA in 13 locales that dead-ends with no error and no telemetry. Holding the merge until the repo is public (or the link goes through a site-owned redirect like /download).
Informational
-
src/app/globals.css:263—!importantmasks a specificity trap and inverts the nav hierarchy..site-header .nav-link/.site-header-paper .nav-link(specificity 0,2,0) beat a bare class — that's why!importantwas needed, and it's also why the existing.nav-link-try { color: var(--gold-dim) }is silently dead. Net effect: "Try Franklin" (the primary product CTA) renders gray while "Download Desktop" becomes the only gold, weight-500 item in the nav. Suggested fix: scoped selectors (.site-header .nav-link-desktop, .site-header-paper .nav-link-desktop) with no!important, and decide whether.nav-link-tryshould get the same treatment so the product CTA isn't outranked. -
Nav overflow at 1121–1280px in long locales. The desktop nav doesn't collapse until 1120px,
.hdr-innercaps at 1180px, and.nav-linkhas nowhite-space: nowrap. The new label is much wider than English in ja (デスクトップ版をダウンロード), ar, ru, ur — links can wrap inside the fixed 72px header. Suggestwhite-space: nowrapon.nav-linkplus verifying ja/ru/ar/ur at 1121–1280px (raising the collapse breakpoint to ~1280px may be needed). -
Dark-theme contrast. After visiting
/chatin dark mode,data-theme="dark"persists on<html>across client-side navigation;--gold-dimbecomes#d8be58on the near-white header (~1.8:1 contrast), and the!importantpins it. Worth verifying whether the dark-theme leak onto marketing pages is in scope. -
Pre-existing, surfaced while testing this change: in the 1024–1120px window the hamburger is shown but
.mobile-menunever getsdisplay: flex(only@media (max-width: 1023px)sets it), so the menu — including this new link — is unreachable there. -
Copy nit: ru "Скачать приложение" drops "Desktop" entirely, which is ambiguous next to the web app the same nav promotes. Also, no accessible indication of the external new-tab jump (matches the existing BlockRun link's gap — fine to fix together or skip).
Notes: all 13 locale dictionaries + types.ts are covered (verified against src/lib/locales.ts), CI is green, rel="noreferrer" is correct. Findings came from a cross-model adversarial review (Claude + Codex); both independently flagged the private-repo 404 as the blocker.
2 participants
Summary
Validation
git diff --checkReady for review.