fix(models): preserve picker order#201
Open
0xCheetah1 wants to merge 4 commits into
Open
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughVISIBLE_OPENCLAW_MODELS now follows TOP_MODELS order through an OPENCLAW_MODEL_BY_ID lookup. top-models.json is reordered and one model ID is removed. A test checks ordering and length. PartnerCategory formatting changes to a multi-line union. ChangesTop models ordering
Partner category type formatting
Estimated code review effort: 2 (Simple) | ~10 minutes Sequence Diagram(s)sequenceDiagram
participant TopModels as TOP_MODELS
participant ModelsTs as models.ts
participant ModelMap as OPENCLAW_MODEL_BY_ID
participant Visible as VISIBLE_OPENCLAW_MODELS
ModelsTs->>TopModels: iterate ids in order
ModelsTs->>ModelMap: get(id)
ModelMap-->>ModelsTs: matched model or undefined
ModelsTs->>Visible: append matches (flatMap)
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
top-models.jsonorder when building the visible OpenClaw model listtop-models.jsonTesting
npx -y -p node@22 npm testnpx -y -p node@22 npm run typechecknpx -y -p node@22 npm run lintnpx -y -p node@22 npm run format:checknpx -y -p node@22 npm run buildSummary by CodeRabbit