Go refactoring 2#2392
Draft
agbishop wants to merge 132 commits into
Draft
Conversation
…mes), drop nolint Pure reorganization, behavior identical (verbatim AST moves). backend.go (2621) + backend_ops/ agents/agents_batch3 + handler.go (2747) split into 51 op-family files using the new naming (store.go core, models.go, errors.go, <family>.go for logic, handler_<family>.go for HTTP; ZERO 'backend' in filenames; max 747). 18 goofy test files (batch1/accuracy*/ops_batch2_audit/ parity_a-b/agents_batch3) -> 37 family test files + test_helpers_test.go (340 tests preserved). Refactored 5 funlen/cyclop/gocyclo nolints (Reset, ExtractOperation, dispatch*) into helpers. Zero new nolint. Whole package green (build/test-race/vet/fix/gofmt/lint 0 issues). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
… names), drop nolint Pure reorganization, behavior identical (verbatim AST moves). backend.go (3887) + handler.go (4083) + proxy.go (1963) split into 62 op-family files (store.go, models.go, errors.go, <family>.go, handler_<family>.go, proxy_<concern>.go; ZERO 'backend' in filenames; max 856). backend_destub/handler_stubs absorbed. 12 goofy test files (accuracy_*/apigw_batch2/boost/ destub/parity_*/coverage) -> 22 family test files (265 tests preserved). Removed funlen + refactored 9 gocognit-flagged action dispatchers into named methods; removed 2 stale dupl. Zero new nolint. Whole package green (build/test-race/vet/fix/gofmt/lint 0 issues). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Pure reorganization, behavior identical (verbatim moves; trust-policy/JWT/SAML logic untouched). backend.go (2156) + backend_accuracy + trustpolicy + tokenvalidation + handler.go (829) split into op-family files (store.go, errors.go, models.go, <family>.go, handler_<family>.go; ZERO 'backend' in filenames; max 612). ~13 goofy test files (batch2_audit/ accuracy/refinement1-4/new_operations/new_ops2/parity_*) -> 22 family test files (0 cases lost). No funlen/gocyclo nolints (none existed); zero new nolint. Whole package green (build/test-race/vet/fix/gofmt/lint 0 issues). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Pure reorganization, behavior identical (verbatim moves; ASL interpreter untouched). backend.go (2683) + handler.go (1452) split into op-family files (store.go, errors.go, interfaces.go, <family>.go, handler_<family>.go; ZERO 'backend' in filenames; max 762). 13 goofy test files (accuracy_audit/batch1-2_audit/coverage*/new_operations/parity_*/ refinement1/comprehensive) -> family test files (cases preserved). No funlen/gocyclo nolints (none existed); zero new nolint. Whole package green (build/test-race/vet/fix/gofmt/lint). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Pure reorganization, behavior identical (verbatim moves; retention-period idempotent fix preserved). backend.go (2410) + handler.go (2195) + types.go->models.go (592) split into 39 op-family files (store.go, interfaces.go, <family>.go, handler_<family>.go; ZERO 'backend' in filenames; max 592). 14 goofy test files (parity_*/coverage_ops/batch7/reshard/ accuracy_batch2/refinement1-3/audit2/new_ops) -> 21 family test files (cases preserved). Fixed one mis-attached doc comment (cosmetic). No funlen/gocyclo nolints (none existed); zero new nolint. Whole package green (build/test-race/vet/fix/gofmt/lint). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Pure reorganization, behavior identical (verbatim AST moves; XML/query wire shapes preserved). backend.go (1467) + missing_ops.go (1085) + handler.go (2872) split into 26 op-family files (store.go, models.go, errors.go, <family>.go, handler_<family>.go; ZERO 'backend' in filenames; max 804). 13 goofy test files (coverage_boost/accuracy*/batch2/new_ops/refinement1/ parity_*) -> family test files (344 tests preserved, 184 goofy prefixes stripped). No funlen/gocyclo nolints (none existed); zero new nolint. Whole package green. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
…wed size 0) DescribeTable's TableSizeBytes/ItemCount read table.totalItemSizeBytes/itemSizes correctly, but the BatchWriteItem paths (handleBatchPutWithIndex, applyBatchDeletes) never updated those parallel bookkeeping slices — only doPut/deleteItemAtIndex did. So a table seeded via BatchWriteItem (the common bulk path) reported TableSizeBytes:0 forever (dashboard 'size 0' with 40 items), and the itemSizes/Items slices could drift out of length-sync -> latent index-out-of-range risk (incl. global-table replica cloning). Fix: batch put/delete now keep itemSizes + totalItemSizeBytes in lockstep via the existing CalculateItemSize helper, mirroring doPut/deleteItemAtIndex. All under the existing table.mu.Lock; no lock-order change. +TestDescribeTable_BatchWriteItem_TableSizeBytesMatchesItems (fails pre-fix). Fixes gopherstack-0mtk. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Pure reorganization, behavior identical (verbatim moves; KMS sealing/crypto untouched). backend.go (3037) + handler.go (632) split into op-family files (store.go, errors.go, <family>.go, handler_<family>.go; ZERO 'backend' in filenames; max 774). 17 goofy test files (accuracy*/audit_sm/batch1_audit/new_ops/parity_*/refinement1-2) -> clean per-op-family test files + helpers_test.go (1547 assertions preserved). Table-driven consolidations (cron/random password/resource policy). No funlen/gocyclo nolints (none existed); dupl fixed via generic decodeAction helper; zero new nolint. Whole package green. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
…tigation) Regression coverage for enforceBucketRegion / cross-region 301 PermanentRedirect + global ListBuckets (previously zero coverage). Investigation of the dashboard S3 'select a region' bug (gopherstack-pejf) proved the Go transport is correct: ListBuckets is global, cross-region access returns 301 + X-Amz-Bucket-Region, CreateBucket threads region properly, and config.DefaultRegion is us-east-1 (not ap-southeast-1). The bug lives in the compiled SvelteKit frontend's client-side region reactivity (not in this repo's Go source). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Pure reorganization, behavior identical (verbatim moves). backend.go (3352) + handler.go (1950) + models.go (1034) split into op-family files (store.go, errors.go, interfaces.go, <family>.go, models_<family>.go, handler_<family>.go; ZERO 'backend' in filenames; max 745). 10 goofy test files (parity_a/accuracy_batch2/refinement1/3/new_ops/coverage*/audit1/2/2b) -> 33 family test files (296 tests preserved); stripped goofy Test prefixes. No funlen/gocyclo nolints (none existed); zero new nolint. Whole package green. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Pure reorganization, behavior identical (verbatim moves). backend.go (1337) + backend_new_ops (629) + backend_remaining_ops (1456) + handler.go (2152) + handler_remaining_ops (1134) split into op-family files (store.go, models.go, errors.go, helpers.go, <family>.go, handler_<family>.go; ZERO 'backend' in filenames; max 529). 8 goofy test files (coverage/ accuracy/audit2/new_ops/refinement1/parity/batch1-2_accuracy) -> family test files (245 tests); stripped goofy Test prefixes. Refactored CreateCluster to drop 1 nolint:funlen. Zero new nolint. Whole package green. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Pure reorganization, behavior identical (verbatim moves; XML/query + rpcv2cbor wire shapes preserved). backend.go (3406) + backend_accuracy (531) + handler.go (2966) + rpcv2cbor.go (2275) split into 55 op-family files (store.go, models.go, errors.go, <family>.go, handler_<family>.go, rpcv2cbor_<family>.go; ZERO 'backend' in filenames; max 919). 10 goofy test files (accuracy/batch1-2/audit_cw/coverage*/parity) -> 30 family test files (357 tests); stripped goofy Test prefixes; table-driven consolidations. No funlen/gocyclo nolints (none existed); zero new nolint. Whole package green. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
… names) Pure reorganization, behavior identical (verbatim moves) + one required refactor. backend.go (2952) + handler.go (2231) split into one file per op-family: store.go, models.go, errors.go, interfaces.go (renamed from backend_iface.go), docker_registry.go (renamed from registry.go), plus repositories/layers/images/image_scanning/pull_through_cache/lifecycle_policy/ repository_creation_templates/registry_policy/replication/repository_policy/ signing/account_settings/tags.go and their handler_<family>.go counterparts. Zero 'backend' in any filename; largest file 587 lines. Removed the package's only nolint (cyclop on classifyError) by replacing the ~20-branch switch with a small lookup-table loop; error-code mapping is byte-identical. 20 goofy/giant test files (parity_*, batch1/2, refinement1/2, accuracy, audit, ops2 sweeps totaling ~12k lines) consolidated into 25 family-aligned test files, all <=1500 lines. Stripped ~150 goofy Test-func prefixes, deduplicated ~8 near-identical test helper constructors down to one shared pair, converted several near-identical standalone tests into table-driven subtests. All original test scenarios preserved (verified via a full before/after Test-func-name diff; 5 scenarios dropped during the mechanical split were caught and restored). Whole package green: go build, go vet, go test -race, go fix -diff, golangci-lint (0 issues, no new nolint), gofmt all pass. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Pure reorganization, behavior identical (verbatim moves; MSK tag-route MatchPriority fix preserved: kafkaMatchPriority = PriorityPathVersioned+1). backend.go (2530) + handler.go (3312) split into 30 op-family files (store.go, models.go, errors.go, <family>.go, routes.go, handler_<family>.go; ZERO 'backend' in filenames; max 808). 10 goofy test files (parity_a-c/ refinement1-2/accuracy_batch2/coverage*/route_matcher_fixes) -> 24 family test files; stripped goofy Test prefixes; 4 not-found tests folded table-driven. No funlen/gocyclo nolints (none existed); zero new nolint. Whole package green. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Pure reorganization, behavior identical (verbatim moves; MD5OfMessageBody + FIFO SHA256 dedup checksums + their gosec/codeql comments preserved). backend.go (3361) + handler.go (1704) + query.go (1278) + types.go->models.go (850) split into op-family files (store.go, errors.go, <family>.go, handler_<family>.go, query_<family>.go; ZERO 'backend' in filenames; max 850). Goofy test files (accuracy*/coverage/refinement1/parity_*/audit_sqs/issue*) -> family test files (362 tests preserved). Refactored dispatchQueryAction into a queryActionTable map-dispatch to drop 1 nolint:cyclop. Zero new nolint. Whole package green. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Pure reorganization, behavior identical (verbatim moves; server OFFLINE->STARTING->ONLINE lifecycle + cascade-delete live-verified against the running binary). backend.go (3232) + handler.go (3477) split into op-family files (store.go, models.go, errors.go, <family>.go, handler_<family>.go; ZERO 'backend' in filenames; max 645). Goofy test files (parity_a-b/ audit2/refinement1-2/new_ops*/accuracy) -> 27 family test files (~240 tests preserved); stripped goofy Test prefixes. No funlen/gocyclo nolints (none existed); zero new nolint. Whole package green. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Pure reorganization, behavior identical (verbatim moves). backend.go (2709) + handler.go (1781) split into op-family files (store.go, errors.go, ids.go, arn.go, models.go, <family>.go, handler_<family>.go; ZERO 'backend' in filenames; max 520). 15 goofy test files (children_index/coverage_ops/audit1-3/batch2_accuracy/extra/new_ops/pagination_gaps/ refinement1) -> 22 family test files (211 tests preserved); stripped goofy Test prefixes; 2 table-driven consolidations. No funlen/gocyclo nolints (none existed); zero new nolint. Whole package green. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Pure reorganization, behavior identical (verbatim moves, diff-verified byte-for-byte). backend.go (3085) + handler.go (3195) split into 28 op-family files (store.go, models.go, errors.go, <family>.go, handler_<family>.go; ZERO 'backend' in filenames; max 747). Goofy dispatchExtended/NewOps chain renamed to per-family dispatchers (70 cases verified identical). 9 goofy test files (parity/batch1-2/refinement1-2/accuracy_batch2/coverage/failover) -> family test files (284 tests, 11 true dups removed). No funlen/gocyclo nolints (none existed); zero new nolint. Whole package green. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Pure reorganization, behavior identical (verbatim moves; Tags []Tag list, base64 File/Content, job lifecycle advance, Directionality all preserved). backend.go (1556) + backend_accuracy (563) + handler.go (808) + handler_ops (1146) split into op-family files (store.go, models.go, errors.go, <family>.go, handler_<family>.go; ZERO 'backend' in filenames; max 343). 8 goofy test files (backend/accuracy/refinement1-2/parity_a-c/validation) -> family test files (105 tests). Refactored 2 dupl nolints via generic applyListOrURI helper. Zero new nolint. Whole package green. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Pure reorganization, behavior identical (verbatim moves). backend.go (1390) + handler.go (666) split into op-family files (store.go, errors.go, validation.go, <family>.go, handler_<family>.go; ZERO 'backend' in filenames; max 501). 11 goofy test files (lifecycle_ parity/ops_batch2_audit/aws_parity/parity_pass1/audit_batch1-2/refinement1/accuracy/new_ operations) -> family test files (273 tests, 12 dups merged). No funlen/gocyclo nolints (none existed); zero new nolint. Whole package green. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Pure reorganization, behavior identical (verbatim moves). backend.go (1163) + handler.go (1624) split into op-family files (store.go, models.go, errors.go, validation.go, <family>.go, handler_<family>.go; ZERO 'backend' in filenames; max 338; batch_load_tasks.go is a legit op-family). 9 goofy test files (accuracy/accuracy2/batch2_accuracy/refinement1-3/parity_a-b) -> family test files (213 tests, 9 dups removed). No funlen/gocyclo nolints (none existed); zero new nolint. Whole package green. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Pure reorganization, behavior identical (verbatim moves). backend.go (2250) + handler.go (1096) split into op-family files (store.go, models.go, errors.go, delivery_streams.go, records.go, delivery_<dest>.go, flush.go, <family>.go, handler_<family>.go; ZERO 'backend' in filenames; max 588). 8 goofy test files (audit_firehose/parity_a-b/parity_firehose/ accuracy/accuracy_batch2-3/refinement1) -> family test files; stripped goofy Test prefixes. No funlen/gocyclo nolints (none existed); zero new nolint. Whole package green. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Pure reorganization, behavior identical (verbatim moves; SHA256 tree-hash logic preserved). backend.go (1439) + handler.go (2110) split into op-family files (store.go, models.go, errors.go, interfaces.go, <family>.go, handler_<family>.go; ZERO 'backend' in filenames; max 756). 11 goofy test files (wire_parity/parity_b/ops_audit/refinement1-2/accuracy*/new_ ops/deepen) -> 22 family test files (194 tests, 1 dup removed). No funlen/gocyclo nolints (none existed); zero new nolint. Whole package green. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Pure reorganization, behavior identical (verbatim moves). backend.go (2899) + handler.go (2726) split into 37 op-family files (store.go, models.go, errors.go, <family>.go, handler_<family>.go; ZERO 'backend' in filenames; max 485). 9 goofy test files (coverage_ops/ audit/new_ops/refinement1-3/parity_a-b) -> family test files (141 tests, 6 dups removed). No funlen/gocyclo nolints (none existed); zero new nolint. Whole package green. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Pure reorganization, behavior identical (verbatim AST moves). backend.go (2219) + handler.go (1744) + handler_missing_ops (388) split into 38 op-family files (store.go, models.go, errors.go, <family>.go, handler_<family>.go; ZERO 'backend' in filenames; max 506). 9 goofy test files (parity/accuracy/refinement1-2/new_ops/deepen/audit_batch1) -> 28 family test files (236 tests, 3 dups removed). No funlen/gocyclo nolints (none existed); zero new nolint. Whole package green. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| // API contract — switching it to SHA-256 would produce a checksum no real SQS client | ||
| // recognizes or can verify against, breaking emulator parity. | ||
| func computeBodyChecksumMD5(body string) string { | ||
| hash := md5.Sum([]byte(body)) //nolint:gosec // wire-protocol checksum, not a security hash |
| // AWS SQS uses SHA-256 (not MD5) when generating the MessageDeduplicationId | ||
| // for content-based deduplication on FIFO queues. | ||
| func computeSHA256(body string) string { | ||
| hash := sha256.Sum256([]byte(body)) |
Pure reorganization, behavior identical (verbatim moves). backend.go (1712) + handler.go (1378) split into op-family files (store.go, models.go, errors.go, <family>.go, handler_<family>.go; ZERO 'backend' in filenames; max 440). 7 goofy test files (coverage_ops/ accuracy_batch2/refinement1-3/parity_b-c) -> 13 family test files (202 tests). No funlen/ gocyclo nolints (none existed); zero new nolint. Whole package green. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Pure reorganization, behavior identical (verbatim moves). backend.go (2453) + handler.go (1305) split into op-family files (store.go, models.go, errors.go, synthetic_blocks.go, <family>.go, handler_<family>.go; ZERO 'backend' in filenames; max 590). 7 goofy test files (lifecycle/accuracy/audit1/ops_batch2_audit/refinement1/parity_a-c) -> family test files (167 tests). No funlen/gocyclo nolints (none existed); zero new nolint. Whole package green. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Pure reorganization, behavior identical (verbatim moves). backend.go (1637) + handler.go (1129) split into op-family files (store.go, models.go, errors.go, brokers.go, users.go, configurations.go, <family>.go, handler_<family>.go; ZERO 'backend' in filenames; max 717). 9 goofy test files (accuracy/audit2/batch2_accuracy/parity_batch1/refinement1/parity_b/ parity_extension/wire_shape_fixes) -> family test files (all cases preserved, verified). No funlen/gocyclo nolints (none existed); zero new nolint. Whole package green. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Pure reorganization, behavior identical (verbatim moves). backend.go (2634) + handler.go (2793) split into op-family files (store.go, models.go, errors.go, <family>.go, handler_<family>.go; ZERO 'backend' in filenames; max 435). 8 goofy test files (audit_batch1/ coverage_boost/refinement1/new_operations/new_ops/parity_a/parity_pass5/r53r_coverage) -> 13 family test files (146 tests). Refactored buildOps into per-family opsX() to drop 1 nolint:funlen; added shared generic helpers (paginate/mapSlice/getSimpleConfig). Zero new nolint. Whole package green. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Pure reorganization, behavior identical (verbatim moves; awsjson1.1 target routing byte-identical). backend.go (2121) -> 14 op-family files (match_sets grouped at 810 to avoid cross-file dupl); handler.go (1737) -> core dispatch (287) + 11 handler_<family>.go. ZERO 'backend' in filenames; max 810. Goofy tests (backend/audit1/audit2/parity_a/parity_b) -> family test files (75 tests). Zero nolint. Whole package green. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Pure reorganization, behavior identical (verbatim moves; awsjson1.1 target routing byte-identical). backend.go (695) -> store.go (generic CRUD)/models.go/errors.go; handler.go (1250) -> core dispatch (288) + 8 handler_<family>.go. ZERO 'backend' in filenames; max 772. Goofy tests (backend/audit1/ ops_batch2_audit/parity_audit/parity_pass5) -> family test files; duplicate raw-request helper trios consolidated. Zero nolint. Whole package green. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Pure reorganization, behavior identical (verbatim moves; 1047-entry signature diff = zero code loss; restjson1 routing preserved). backend.go (2666) -> 12 op-family files; interfaces.go (1129) -> interfaces.go + types.go; handler.go (3552) + handler_appendixa.go (1482) -> core dispatch + paths + 8 handler_<family>.go. ZERO 'backend'/'appendix' in filenames; max 961. Goofy tests (appendixa/audit1/paritysweep/parity_c/appendixbatch/finalstub) -> family test files (131 tests). Zero new nolint; 13 pre-existing on flat routing switches (qualifying exception). Package green. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Pure reorganization, behavior identical (verbatim moves; restjson1 routing preserved). backend.go (1064) + backend_ops.go (2471) -> 19 op-family files + store/errors/models/wire; handler.go (2037) + handler_ops.go (1854) -> core dispatch (659) + 16 handler_<family>.go. ZERO 'backend'/'_ops' in filenames; max 957. 13 goofy test files (audit1-6/coverage/coverage2/parity/ refinement1/ops_batch2_audit, 13k lines) -> 24 family test files (270 tests verified identical). Zero new nolint. Whole package green. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
# Conflicts: # services/eventbridge/backend_core.go # services/eventbridge/store.go
Pure reorganization, behavior identical (AST-verified verbatim moves; awsjson1.1 target routing preserved). backend.go (1460) -> 9 op-family files; handler.go (1663) -> core dispatch (454) + 6 handler_<family>.go. ZERO 'backend' in filenames; max 756. Goofy tests (backend/refinement1/ parity_pass1/newops + giant handler_test 1414) -> family test files (89 tests decl-verified). Zero nolint. Whole package green. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Pure reorganization, behavior identical (verbatim moves; restjson1 routing preserved). backend.go (1199) -> 8 op-family files; handler.go (1397) -> core dispatch (421) + 6 handler_<family>.go. ZERO 'backend' in filenames; max 727. Goofy tests (coverage_boost/audit1/ audit2/parity_a + dummy_linter/test_linter placeholders) -> family test files (58 tests verified). Removed 4 stale dupl nolints (net 10->6); zero new nolint. Whole package green. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Pure reorganization, behavior identical (verbatim moves; awsjson1.1 target routing preserved). backend.go (723) -> 7 op-family files; handler.go (1094) -> core dispatch (272) + 6 handler_<family>.go. ZERO 'backend'/'_ops' in filenames; max 602. Goofy tests (backend/audit1/ ops_batch2_audit/parity_a/parity) -> family test files (69 tests). Zero nolint. Package green. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Pure reorganization, behavior identical (sed range-verified verbatim moves; awsjson1.1 target routing preserved). backend.go (2082) -> 18 op-family files; handler.go (1832) -> core dispatch (354) + 13 handler_<family>.go. ZERO 'backend' in filenames; max 354. Goofy tests (audit1) -> 16 family test files (41 tests). Batch inference/segment jobs merged into batch_jobs.go to avoid whole-file dupl (no nolint). Zero nolint. Whole package green. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
…mes) Pure reorganization, behavior identical (verbatim moves; Cedar policy-eval logic byte-identical; awsjson1.1 routing preserved). backend.go (1668) -> 10 op-family files; handler.go (1954) -> core dispatch (248) + 7 handler_<family>.go. ZERO 'backend' in filenames; max 705. Goofy tests (backend/ refinement1/parity_a/parity_b/parity_pass6 + giant handler_test 2557) -> family test files (122 tests; 1 exact dup consolidated). Zero new nolint. Whole package green. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Pure reorganization, behavior identical (verbatim moves; restjson1 routing preserved). backend.go (2243) + handler.go (2139) split into op-family <family>.go + handler_<family>.go files (store.go, models.go, errors.go core). ZERO 'backend' in filenames; max 724. Giant handler_test.go (1427) + goofy tests -> family test files. Zero new nolint. Whole package green (build/race/vet/gofmt/golangci-lint 0 issues, verified by main thread). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Pure reorganization, behavior identical (verbatim moves). backend.go (948) -> store.go, monitors.go, probes.go, tags.go; handler.go (672) kept (under cap). ZERO 'backend' in filenames; max 672. Goofy tests (backend/parity_pass1) -> 8 family test files. Zero nolint. Whole package green. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Pure reorganization, behavior identical (verbatim moves; awsjson1.1 target routing preserved). backend.go (2211) -> 21 op-family files; handler.go (2073) -> core dispatch (302) + 17 handler_<family>.go. ZERO 'backend' in filenames; max 494. Goofy tests (audit1/parity_new_ops/ parity_pass5) -> 18 family test files (36 tests). Zero nolint. Whole package green. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Pure reorganization, behavior identical (symbol-diff-verified verbatim moves; restjson1 routing preserved). backend.go (1503) -> 8 op-family files; handler.go (1566) -> core dispatch (639) + 7 handler_<family>.go. ZERO 'backend' in filenames; max 744. Goofy tests (backend/audit/new_ops/ parity/refinement1 + giant handler_test 1791) -> family test files (108 tests verified). Zero nolint. Whole package green. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Pure reorganization, behavior identical (verbatim moves; restjson1 routing preserved). backend.go (3058) -> 11 op-family files; interfaces.go (653) -> interfaces.go + models.go; handler.go (2765) -> core dispatch (762) + routes.go + 11 handler_<family>.go. ZERO 'backend' in filenames; max 762. Goofy tests (parity) -> family test files. 6 pre-existing funlen/cyclop nolints on flat routing tables retained (qualifying exception); zero new nolint. Whole package green. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Pure reorganization, behavior identical (verbatim moves; restjson1 routing byte-identical). backend.go (1651) -> 11 op-family files; handler.go (1555) -> core dispatch (685) + 7 handler_<family>.go; models.go (885) -> models.go + errors.go. ZERO 'backend' in filenames; max 839. Goofy tests (backend/new_ops/refinement1/refinement2/parity_b) -> family test files (98 tests). Zero new nolint. Whole package green. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Pure reorganization, behavior identical (verbatim moves; restjson1 routing byte-identical). backend.go (1388) -> 10 op-family files (store.go core); handler.go (1711) -> core dispatch (465) + 7 handler_<family>.go. ZERO 'backend' in filenames; max 596. Goofy tests (backend/coverage_boost/ parity_pass1) -> family test files (187 tests diff-verified). Zero nolint. Whole package green. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Pure reorganization, behavior identical (verbatim moves). backend.go (670) -> models.go, errors.go, store.go, accuracy_metrics.go (real GetAccuracyMetrics op), tags.go; handler.go (523) kept (under cap). ZERO 'backend' in filenames; max 523. Goofy tests (backend/audit1/parity_a/parity_c) -> family test files (41 tests); goofy Test-func prefixes stripped. Zero nolint. Whole package green. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
… names) Pure reorganization, behavior identical (verbatim moves; restjson1 routing preserved). backend.go + backend_appendixa.go -> 10 op-family files; handler.go + handler_appendixa.go -> core dispatch (414) + 8 handler_<family>.go. ZERO 'backend'/'appendix' in filenames; max 591. Goofy tests (appendixa) -> family test files (36 tests). dispatchAppendixA cyclop/funlen nolint decomposed into 6 family dispatchers; goconst fixed via consts (net nolint decreased). Green. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Pure reorganization, behavior identical (verbatim moves; restjson1 routing byte-identical). backend.go (2191) -> 10 op-family files; handler.go (1444) -> core dispatch (684) + 6 handler_<family>.go. ZERO 'backend' in filenames; max 910 (in band). Goofy tests (accuracy/ accuracy_batch2/refinement1/parity_b + giant handler_test 1921) -> family test files (149 tests). Zero new nolint. Whole package green. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Pure reorganization, behavior identical (verbatim moves; awsjson1.0 target routing byte-identical). backend.go (1545) -> 11 op-family files; handler.go (1705) -> core dispatch (244) + 9 handler_<family>.go. ZERO 'backend'/'_ops' in filenames; max 435. Goofy tests (audit1/ops_batch2_ audit/parity_a) -> 10 family test files (39 tests). Zero new nolint. Whole package green. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Pure reorganization, behavior identical (verbatim moves; restjson1 routing preserved). backend.go (2924) -> 16 op-family files; handler.go (3124) -> core dispatch (393) + handler_ routing.go (642) + 13 handler_<family>.go. ZERO 'backend' in filenames; max 642. Goofy tests (parity) -> family test files. dupl resolved by merging thin op-wiring maps (no nolint). Zero nolint. Whole package green. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Pure reorganization, behavior identical (verbatim moves). backend.go + 4 backend_<family>.go -> op-family files (store.go, stacks.go, fleets.go, applications.go, images.go, users.go, etc.); handler.go (679) kept. ZERO 'backend' in filenames; max 645. Goofy tests (audit1/audit2/audit3/ parity) -> 12 family test files; 3 never-executed dead table cases removed. 1 funlen on flat routing map retained (exception); zero new nolint. Whole package green. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Pure reorganization, behavior identical (verbatim moves). backend.go (460) -> errors.go, models.go, store.go, lifecycle_policies.go, tags.go; handler.go (379) kept. ZERO 'backend' in filenames; max 627. Goofy tests (backend/coverage_boost/audit1/parity_c) -> 8 family test files. Zero nolint. Whole package green. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Pure reorganization, behavior identical (verbatim moves; awsjson1.1 routing preserved). backend.go (1487) -> 6 op-family files; handler.go (961) -> core dispatch (351) + 3 handler_<family>.go. ZERO 'backend' in filenames; max 730. Goofy tests (parity_b/parity_pass6/ refinement2/refinement3 + giant handler_test 1648) -> 10 family test files (155 cases preserved). Zero forbidden nolint. Whole package green. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Pure reorganization, behavior identical (verbatim moves; restjson1 routing preserved). backend.go (1640) -> 9 op-family files; handler.go (1200) -> core dispatch (343) + 6 handler_<family>.go. ZERO 'backend' in filenames; max 765. Goofy tests (audit1/deepen1/ refinement1/parity_pass1/parity_validation + giant handler_test 1507) -> family test files (170 tests preserved). Zero nolint. Whole package green. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Collaborator
Author
📊 Code Coverage Report
Tip This project maintains a minimum coverage threshold of 85%. Maintain or improve coverage on new code to ensure long-term stability. Last updated: Sat, 18 Jul 2026 04:34:19 GMT |
Pure reorganization, behavior identical (AST-verified verbatim moves; awsjson1.1 routing preserved, 97 ops sorted-diff empty). backend.go + backend_ext.go + backend_real.go merged -> 14 op-family files; handler.go + handler_ext.go -> core dispatch (277) + 11 handler_<family>.go. ZERO 'backend'/ 'ext'/'real' in filenames; max 725. Goofy tests (backend/backend_real/coverage/parity_a + giant handler_test 1519) -> 21 family test files (110 tests AST-verified). Zero new nolint. Green. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Pure reorganization, behavior identical (verbatim moves; routing preserved). backend.go (453) -> errors.go, models.go, store.go, contacts.go, regions.go, account_info.go; handler.go (621) kept. ZERO 'backend' in filenames; max 621. Goofy tests (backend + oversized handler_test 986) -> family test files. Zero nolint. Whole package green. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Pure rename/reorg (verbatim content; crypto/policy-eval logic byte-identical). ~28 backend_ <family>.go -> <family>.go (backend.go -> store.go, backend_iface.go -> interfaces.go, backend_ audit.go -> audit.go [real IoT Device Defender feature]); backend_persistence_ext folded into persistence.go. ZERO 'backend'/'iface' in filenames; max 984 (in band). Goofy tests (backend/ persistence_gap + oversized handler_test 1007) -> family test files; goofy func names/doc-comments fixed. Zero forbidden nolint. Whole package green. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.