Skip to content

CGD-576: Remove unreachable _counter undefined guard in abstract-eth #8504

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
pritam-gembali wants to merge 1 commit into from
Closed

CGD-576: Remove unreachable _counter undefined guard in abstract-eth #8504

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions modules/abstract-eth/src/lib/transactionBuilder.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -386,9 +386,6 @@ export abstract class TransactionBuilder extends BaseTransactionBuilder {
if (this._common === undefined) {
throw new BuildTransactionError('Invalid transaction: network common');
}
if (this._counter === undefined) {
throw new BuildTransactionError('Invalid transaction: missing address counter');
}
}

/** @inheritdoc */
Expand Down
4 changes: 0 additions & 4 deletions modules/sdk-coin-eth/test/unit/transactionBuilder/walletInitialization.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -340,20 +340,16 @@ describe('Eth Transaction builder wallet initialization', function () {

it('a transaction to build', async () => {
const txBuilder: any = getBuilder('eth');
txBuilder.counter(undefined);
txBuilder.type(TransactionType.WalletInitialization);
assert.throws(() => txBuilder.validateTransaction(), /Invalid transaction: missing fee/);
txBuilder.fee({
fee: '10',
gasLimit: '1000',
});
assert.throws(() => txBuilder.validateTransaction(), /Invalid transaction: missing address counter/);
assert.throws(() => txBuilder.validateTransaction(), /Invalid transaction: missing address counter/);
const source = {
prv: sourcePrv,
};
const sourceKeyPair = new KeyPair(source);
assert.throws(() => txBuilder.validateTransaction(), /Invalid transaction: missing address counter/);
txBuilder.counter(1);
assert.throws(() => txBuilder.validateTransaction(), /wrong number of owners -- required: 3, found: 0/);
txBuilder.owner(sourceKeyPair.getAddress());
Expand Down
Loading