fix(sdk-lib-mpc): throw in Dsg.endSession() when signature exists#8497
Merged
zahin-mohammad merged 1 commit intomasterfrom Apr 17, 2026
Merged
fix(sdk-lib-mpc): throw in Dsg.endSession() when signature exists#8497zahin-mohammad merged 1 commit intomasterfrom
zahin-mohammad merged 1 commit intomasterfrom
Conversation
zahin-mohammad
approved these changes
Apr 16, 2026
Marzooqa
previously approved these changes
Apr 16, 2026
mrdanish26
previously approved these changes
Apr 16, 2026
mohammadalfaiyazbitgo
force-pushed
the
fix/wal-383-dsg-end-session-throw
branch
from
4ad5dd7 to
10e94a7
Compare
zahin-mohammad
previously approved these changes
Apr 16, 2026
bitgo-ai-agent-dev
bot
force-pushed
the
fix/wal-383-dsg-end-session-throw
branch
from
10e94a7 to
c664793
Compare
pranavjain97
previously approved these changes
Apr 16, 2026
Without the throw, endSession() silently reset dsgState to Uninitialized after signing, allowing init() to succeed again and enabling inadvertent session reuse on the same key share. Ticket: WAL-383
mohammadalfaiyazbitgo
dismissed stale reviews from pranavjain97, zahin-mohammad, Marzooqa, and mrdanish26
via
2cdae61
mohammadalfaiyazbitgo
force-pushed
the
fix/wal-383-dsg-end-session-throw
branch
from
c664793 to
2cdae61
Compare
mohammadalfaiyazbitgo
requested review from
Marzooqa,
pranavjain97 and
zahin-mohammad
zahin-mohammad
approved these changes
Apr 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Dsg.endSession()atdsg.ts:167was constructingnew Error(...)withoutthrow, silently resettingdsgStatetoUninitializedafter signinginit()call would succeed, enabling inadvertent session reuse on the same key sharethrowto the existingnew Error(...)callTest plan
endSession()throws when signature is already producedTicket: WAL-383
🤖 Generated with Claude Code