fix(sdk-lib-mpc): handle WaitMsg4 round in _deserializeState#8467
Merged
zahin-mohammad merged 1 commit intomasterfrom Apr 10, 2026
Conversation
_deserializeState() used a switch on string cases but at Round 4 the
CBOR-decoded round is an object { WaitMsg4: { r: ... } }, not a string.
This made it always throw InvalidState at Round 4, inconsistent with
setSession() which correctly handles it. Convert the switch to if/else if
to support the mixed string/object round type.
WAL-384
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
zahin-mohammad
commented
Apr 9, 2026
mrdanish26
approved these changes
Apr 9, 2026
mohammadalfaiyazbitgo
approved these changes
Apr 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_deserializeState()missingWaitMsg4case in DKLS DSG — at Round 4 the CBOR-decoded round is an object{ WaitMsg4: { r: ... } }, not a string, causingInvalidStateto be thrownswitchtoif/else ifto support the mixed string/object round type, consistent with howsetSession()already handles it_deserializeState()correctly handles theWaitMsg4round stateTest plan
_deserializeState()at WaitMsg4 state and verifiesDsgState.Round4is set without throwingTicket: WAL-384
🤖 Generated with Claude Code