fix(sdk-lib-mpc): re-derive dkgState from WASM bytes in restoreSession#8466
Open
mohammadalfaiyazbitgo wants to merge 1 commit intomasterfrom
Open
fix(sdk-lib-mpc): re-derive dkgState from WASM bytes in restoreSession#8466mohammadalfaiyazbitgo wants to merge 1 commit intomasterfrom
mohammadalfaiyazbitgo wants to merge 1 commit intomasterfrom
Conversation
Call _deserializeState() after _restoreSession() so dkgState is always derived from the actual WASM bytes instead of the caller-supplied value. When keyShareBuff is present, override state to Complete since the WASM bytes still reflect WaitMsg4 after keyshare() frees the session. Adds a regression test verifying tampered dkgState is ignored. WAL-396 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Comment on lines
+356
to
+360
| if (sessionData.keyShareBuff) { | ||
| // After keyshare() is called the WASM session is freed and dkgSessionBytes still reflect WaitMsg4. | ||
| // Presence of keyShareBuff is the reliable signal that the protocol completed. | ||
| dkg.dkgState = DkgState.Complete; | ||
| } |
Contributor
There was a problem hiding this comment.
Shouldn't this be handled by _deserializeState
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Dkg.restoreSession()now calls_deserializeState()after_restoreSession()to always derivedkgStatefrom the actual WASM bytes, ignoring the caller-supplied value inDkgSessionDataCompletestate override whenkeyShareBuffis present, since the WASM bytes still reflectWaitMsg4afterkeyshare()frees the sessiondkgStatein session data is ignored on restoreTest plan
yarn run unit-test --scope @bitgo/sdk-lib-mpc -- -- --grep "restoreSession"— new tampered-state test passesyarn run unit-test --scope @bitgo/sdk-lib-mpc— all existing DKG round-trip tests continue to passWAL-396
🤖 Generated with Claude Code