Skip to content

fix(sdk-lib-mpc): validate messageHash length in Dsg.init() #8447

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mohammadalfaiyazbitgo merged 1 commit into from
Apr 10, 2026
+13 −0
Merged

fix(sdk-lib-mpc): validate messageHash length in Dsg.init() #8447

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions modules/sdk-lib-mpc/src/tss/ecdsa-dkls/dsg.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,6 +119,9 @@ export class Dsg {
if (this.dsgState !== DsgState.Uninitialized) {
throw Error('DSG session already initialized');
}
if (this.messageHash.length !== 32) {
throw Error(`Invalid messageHash length: expected 32 bytes (SHA-256), got ${this.messageHash.length}`);
}
if (!this.dklsWasm) {
await this.loadDklsWasm();
}
Expand Down
10 changes: 10 additions & 0 deletions modules/sdk-lib-mpc/test/unit/tss/ecdsa/dklsDsg.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -207,6 +207,16 @@ describe('DKLS Dsg 2x3', function () {
should.exist(convertedSignature);
});

it('should throw if messageHash is not 32 bytes', async function () {
const party = new DklsDsg.Dsg(fs.readFileSync(shareFiles[0]), 0, 'm', Buffer.alloc(31));
await party.init().should.be.rejectedWith(/Invalid messageHash length/);
});

it('should throw if messageHash is empty', async function () {
const party = new DklsDsg.Dsg(fs.readFileSync(shareFiles[0]), 0, 'm', Buffer.alloc(0));
await party.init().should.be.rejectedWith(/Invalid messageHash length/);
});

it(`should fail when signing two different messages`, async function () {
const party1 = new DklsDsg.Dsg(
fs.readFileSync(`${__dirname}/fixtures/userShare`),
Expand Down
Loading