feat(statics): add Boba Network (EVM) with ERC20 token support#8440
Merged
bhavesh-prasad merged 1 commit intomasterfrom Apr 10, 2026
Merged
feat(statics): add Boba Network (EVM) with ERC20 token support#8440bhavesh-prasad merged 1 commit intomasterfrom
bhavesh-prasad merged 1 commit intomasterfrom
Conversation
Contributor
mullapudipruthvik
left a comment
There was a problem hiding this comment.
Code review
Found 1 issue:
Critical (score 95):
BobaTestnetclass uses mainnet chain ID (288), mainnet explorer URLs, and mainnet-derived operation hash prefixes — all three should differ from the mainnetBobaclass. Boba Sepolia testnet chain ID is 28882 (confirmed by the testnet explorer URL added inenvironments.ts:/evm/28882/). Every other EVM testnet in this file uses a distinct chain ID, testnet explorer URL, and matching hash prefix (seeArbitrumTestnetwith 421614,BinanceSmartChainTestnetwith 97, etc.). In production, testnet transactions would be routed to the wrong chain and explorer links would show mainnet data.chainIdshould be28882,nativeCoinOperationHashPrefixandtokenOperationHashPrefixshould be28882, andexplorerUrl/accountExplorerUrlshould use the testnet bobascan domain.
BitGoJS/modules/statics/src/networks.ts
Lines 2565 to 2575 in 0f2e49c
Checked for: CLAUDE.md compliance, bugs, error handling, security, bot-specific failure modes, database operations, code comment accuracy.
0f2e49c to
f4f5de0
Compare
f4f5de0 to
6fcf5a9
Compare
Contributor
Author
|
@mullapudipruthvik I have addressed the comments |
mullapudipruthvik
approved these changes
Apr 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CoinFamily.BOBAandUnderlyingAsset.BOBAto base enumsBoba(chainId: 288) andBobaTestnetnetwork classes innetworks.tsboba(mainnet) andtboba(testnet) coin entries withSUPPORTS_ERC20feature flagBobaERC20Tokenclass andbobaErc20/tbobaErc20factory functions inaccount.tssdk-coreenvironmentsexpectedColdFeaturestest fixture and excludeUnderlyingAsset.BOBAfrom keychains testTicket: CECHO-305