Make AudioNode::info and AudioNode::construct_processor fallible#117
Open
IRSMsoso wants to merge 7 commits intoBillyDM:mainfrom
Open
Make AudioNode::info and AudioNode::construct_processor fallible#117IRSMsoso wants to merge 7 commits intoBillyDM:mainfrom
IRSMsoso wants to merge 7 commits intoBillyDM:mainfrom
Conversation
Author
|
Hmm, not sure what to do about no_std |
Contributor
CorvusPrudens
left a comment
CorvusPrudens
left a comment
There was a problem hiding this comment.
A touch nitpicky, but I think the rest of the changes look good.
CorvusPrudens
approved these changes
Mar 18, 2026
|
|
||
| #[derive(Error, Debug)] | ||
| #[error("ConvolutionNode::CHANNELS cannot be greater than 2, got {0}")] | ||
| pub struct ConvolutionInvalidChannelCount(usize); |
Contributor
There was a problem hiding this comment.
Ah, sorry, let's make sure the field is public!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These methods being fallible allows for node authors to have conditions for which a node cannot be created without panicking. For example, a
ConvolutionNodewith greater than 2 channels.The original motivation for introducing fallibility to these functions was for the implementation of a CLAP plugin node, which can fail instantiation for a multitude of reasons both during the
AudioNode::infostage and theAudioNode::construct_processorstage.@CorvusPrudens suggested using an anyhow-like error type, but wasn't sure how deep those should go before switching to structured
thiserrortypes or simply panicking (which I decided to do for construction of nodes that are currently known to never fail). Suggestions welcome.