Repository navigation
fix(stack): show the Application information tab and its logo in Resource Manager - #4
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What: the stack page in Resource Manager now shows the Application information tab, with the Better Stack logo, the View in Better Stack button and the stack's compartment.
Why: #3 added the logo and button, but neither showed after Apply. Resource Manager lists every output except the button's, and hides the whole tab when that list is empty. The console's image policy also only allows
data:URIs and Oracle domains, so the logo fromraw.githubusercontent.comwas blocked.How: a second output,
betterstack_compartment_id, shown as Compartment. The logo is now inline inschema.yamlas adata:image/pngURI, built fromlogo.png.Tested: a stack with this
schema.yamland both outputs, applied in a trial tenancy, showed the tab with the title, description, logo, Compartment output and View in Better Stack button.terraform validatepasses.