Skip to content

Override assertj-core to 3.27.7 for security fix#484

Merged
thomasturrell merged 3 commits intomainfrom
copilot/override-assertj-version
Feb 4, 2026
Merged

Override assertj-core to 3.27.7 for security fix#484
thomasturrell merged 3 commits intomainfrom
copilot/override-assertj-version

Conversation

Copy link
Contributor

Copilot AI commented Feb 3, 2026

Description

Overrides org.assertj:assertj-core to version 3.27.7 in the root pom.xml to address security advisory https://github.com/BerryCloud/xapi-java/security/dependabot/703.

Spring Boot 4.0.2 transitively pulls in assertj-core 3.27.6. The override in dependencyManagement forces all modules to use the patched version.

Changes

  • Added assertj.version property (3.27.7) in the <properties> section for consistency with project conventions
  • Added org.assertj:assertj-core version override using ${assertj.version} in root pom.xml <dependencyManagement> section

Checklist:

  • Public methods are documented
  • Public methods are tested
  • New and existing tests pass when run locally
  • There are no new warnings or errors

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

Co-authored-by: thomasturrell <1552612+thomasturrell@users.noreply.github.com>
Copilot AI changed the title [WIP] Override AssertJ version to 3.27.7 in root pom.xml Override assertj-core to 3.27.7 for security fix Feb 3, 2026
Copilot AI requested a review from thomasturrell February 3, 2026 23:27
@thomasturrell thomasturrell requested a review from Copilot February 4, 2026 00:17
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR addresses a security vulnerability in the transitive dependency org.assertj:assertj-core by adding a version override in the root pom.xml. The project uses Hamcrest for assertions rather than AssertJ, but AssertJ is pulled in transitively through spring-boot-starter-test dependencies used across multiple modules (xapi-model, xapi-client, and samples).

Changes:

  • Added org.assertj:assertj-core version override (3.27.7) in the root pom.xml <dependencyManagement> section to patch a security vulnerability

@thomasturrell
Copy link
Contributor

@copilot does this even override the assertj-core version used by Spring Boot?

Co-authored-by: thomasturrell <1552612+thomasturrell@users.noreply.github.com>
Copy link
Contributor Author

Copilot AI commented Feb 4, 2026

@copilot does this even override the assertj-core version used by Spring Boot?

Yes, it does override the Spring Boot version. You can verify with ./mvnw dependency:tree -Dverbose | grep assertj-core which shows "version managed from 3.27.6" - meaning Spring Boot's 3.27.6 is being overridden by our 3.27.7 in dependencyManagement.

@thomasturrell thomasturrell marked this pull request as ready for review February 4, 2026 19:54
@sonarqubecloud
Copy link

sonarqubecloud bot commented Feb 4, 2026

@thomasturrell thomasturrell merged commit af8caf4 into main Feb 4, 2026
5 checks passed
@thomasturrell thomasturrell deleted the copilot/override-assertj-version branch February 4, 2026 22:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants