Add optional output_dir to write_search_results_to_file()#11
Draft
jason-raitz wants to merge 1 commit intomainfrom
Draft
Add optional output_dir to write_search_results_to_file()#11jason-raitz wants to merge 1 commit intomainfrom
jason-raitz wants to merge 1 commit intomainfrom
Conversation
- adds an optional output_dir parameter to overide the default
jason-raitz
requested review from
anarchivist,
awilfox,
danschmidt5189 and
yzhoubk
anarchivist
approved these changes
Apr 30, 2026
Member
anarchivist
left a comment
anarchivist
left a comment
There was a problem hiding this comment.
don't love the change (i was mostly fine with #10), but it's fine if we're refactoring it soon.
|
|
||
| def write_search_results_to_file( | ||
| self, query: str = "", output_file_name: str = "tind.xml" | ||
| self, query: str = "", output_file_name: str = "tind.xml", output_dir: str = "" |
Member
There was a problem hiding this comment.
i understand this (based on getting up to speed on in slack) but i think adding output_dir honestly makes this more confusing. imo, output_file_name should just take a str | os.PathLike-typed value. but shrug if we're thinking about refactoring this soon anyway...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
non-breaking change