Ap 483 #4
Merged
Ap 483 #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jason-raitz
commented
Nov 4, 2025
jason-raitz
commented
- This pull request updates the TIND API integration to use the correct API endpoints and authentication
- updates some GitHub Actions workflows.
- updates the TIND search API path and parameters, adding support for TIND API key authentication, and updating related tests
danschmidt5189
approved these changes
Nov 4, 2025
Member
danschmidt5189
left a comment
danschmidt5189
left a comment
There was a problem hiding this comment.
I think we need tests that actually hit TIND/Alma rather than the stubs, but given this hotfix and the out-of-band testing we've already done I'm okay merging/releasing this and following up in a different PR.
anarchivist
approved these changes
Nov 4, 2025
Member
anarchivist
left a comment
anarchivist
left a comment
There was a problem hiding this comment.
relatively minor changes/nits; i'm good to merge if we do a followon set of fixes soon after.
Member
There was a problem hiding this comment.
nit: do we need updated fixture data? the /api/v1/search endpoint wraps responses in a <response></response> element.
CHANGES.md
Outdated
| @@ -1,3 +1,7 @@ | |||
| # 0.4.3 (2025-11-04) | |||
|
|
|||
| - Refactor BerkeleyLibrary::AV::Util#do_get to use TIND API key if available in ENV | |||
Member
There was a problem hiding this comment.
the change is more significant than this. make sure we include that we're changing endpoints here.
danschmidt5189
force-pushed
the
ap-483
branch
from
da492f3 to
7195908
Compare
Switches from the public `/search` endpoint to the actual `/api/v1/search` endpoint to retrieve metadata from TIND. Library consumers must set the environment variable LIT_TIND_API_KEY to a suitable TIND API token to authorize this endpoint. At some point in the past week TIND restricted the ability of non-browser/human clients to search records, necessitating this change.
danschmidt5189
force-pushed
the
ap-483
branch
from
7195908 to
370db80
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.