You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Adds an operator to compute the minimum distance between two objects, accounting for shape, size, etc... To vote on the name of this operator, please use this poll.
Issue Link
N/A
Checklist
I have tested the changes locally via pytest and/or other means
I have added or updated relevant documentation
I have autoformatted the code with black and isort
I have added test cases (if applicable)
Additional Notes
Please do not merge until poll results are finalized and I have updated the code to reflect them.
❌ Patch coverage is 95.83333% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 89.88%. Comparing base (8257147) to head (6e53653). ⚠️ Report is 2 commits behind head on main.
The minimum distance to the given Object from ego (or the Object provided with the optional from Object). Unlike :ref:`distance from`, this operator takes into account the Objects' shapes, sizes, etc...
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
The minimum distance to the given Object from ego (or the Object provided with the optional from Object). Unlike :ref:`distance from`, this operator takes into account the Objects' shapes, sizes, etc...
The minimum distance to the given Object from ego (or the Object provided with the optional :scenic:`from {Object}`). Unlike :ref:`distance from`, which computes the distance between the :prop:`position` of the objects, this operator takes into account the objects' :prop:`shape` and dimensions.
The reason will be displayed to describe this comment to others. Learn more.
Looks good (just one comment), but please add a .. note to the Operator Reference section for distance from explaining that when passed objects it just computes the distance between their positions (i.e. their centers), and that if you want to find the separation between two objects taking into account their shape and size you should use minimum distance from.
Also the minimum distance from entry needs a .. version-added directive. You could put version 3.2 for now I guess, or maybe something like "unreleased".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds an operator to compute the minimum distance between two objects, accounting for shape, size, etc... To vote on the name of this operator, please use this poll.
Issue Link
N/A
Checklist
pytestand/or other meansAdditional Notes
Please do not merge until poll results are finalized and I have updated the code to reflect them.