Skip to content

fix: typo Slop->Slot and mark Signal::subscribe() [[nodiscard]] #1199

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
webzuweb wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: typo Slop->Slot and mark Signal::subscribe() [[nodiscard]] #1199

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions include/behaviortree_cpp/utils/signal.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
namespace BT
{
/**
* Super simple Signal/Slop implementation, AKA "Observable pattern".
* Super simple Signal/Slot implementation, AKA "Observable pattern".
* The subscriber is active until it goes out of scope or Subscriber::reset() is called.
*/
template <typename... CallableArgs>
Expand All @@ -34,7 +34,7 @@ class Signal
}
}

Subscriber subscribe(CallableFunction func)
[[nodiscard]] Subscriber subscribe(CallableFunction func)
{
Subscriber sub = std::make_shared<CallableFunction>(std::move(func));
subscribers_.emplace_back(sub);
Expand Down
Loading