Skip to content

Remove TypeScript build artifacts#65

Open
SolarFlurry wants to merge 1 commit intoBedrockCommands:mainfrom
SolarFlurry:main
Open

Remove TypeScript build artifacts#65
SolarFlurry wants to merge 1 commit intoBedrockCommands:mainfrom
SolarFlurry:main

Conversation

@SolarFlurry
Copy link
Copy Markdown

Remove behavior_pack/scripts directory.

Reasons for change

  • There is already behavior_pack/src which is the source of truth, there should not be two
  • removes the need of transpiling the TypeScript code into JS for committing
  • the directory is considered a build artifact of TypeScript transpilation
  • lowers the storage footprint needed to store the repository

@CLAassistant
Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@BrodBlox09
Copy link
Copy Markdown
Contributor

The argument for keeping behavior_pack/scripts is so that less-technical users are able to download the packs directly from GitHub and run it in Minecraft straight away. I 100% agree with you in every way that it would be better to have one source of truth for the code in this project, but we are currently attempting to accommodate to less-technical users.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants