fix(ci): preserve merged PR Swift verification - #11063
Conversation
Failure-Class: none
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
|
Maintainer review signal: this looks like a small, coherent CI fix. I verified the updated Desktop Swift concurrency contract locally ( Because this changes GitHub Actions concurrency for the Swift gate, I'm not formally approving it from automation; please have a maintainer do final workflow review before merge. Thanks for tightening the release-evidence path. by AI on behalf of David — if you need David’s attention urgently, please @Git-on-my-level and escalate with |
|
@Git-on-my-level need human response — your earlier review signal looks good (local contract tests 25/25, concurrency grouping coherent), and CI is fully green on this head. Merging is still blocked on a formal code-owner approve for the Actions concurrency change. Could a human maintainer give the workflow sign-off when you have a moment? |
|
@Git-on-my-level need human response — gentle bump. Head |
|
@Git-on-my-level follow-up: PR #11063 remains fully CI-green at 7b107ee. Cubic is 5/5, your concurrency review found no blocker, and the Desktop Swift contract suite passes 25/25. The only remaining gate is formal workflow code-owner approval. |
Summary
Fixes #10575.
The Desktop Swift CI workflow used the same PR-number concurrency group for
pull_request.closedevents as for active PR verification. When a PR mergedwhile its exact-SHA Swift verification was still running, the closed event
cancelled that verification. The merged code could therefore land without the
required macOS result reaching a terminal state.
Merged-close events now use a distinct no-op concurrency group. They still skip
all jobs, so they do not consume a runner, while the active PR verification is
allowed to finish. Abandoned closed PRs retain the existing PR-number group and
cancellation behavior. Main pushes continue to use immutable SHA groups.
Verification
python3 .github/scripts/test_desktop_swift_ci_contract.pyactionlint .github/workflows/desktop-swift-ci.ymlgit diff --checkInvariants
No product invariants are affected.
Failure-Class: none