Add trusted options to XML functions#2656
Conversation
|
Some feedback:
|
|
Thank you for your comments!
Not adopting
For the same argument as above, this does not currently happen. Yet it feels safer to have it inherited, so the change covers this as well.
The implementation in this PR assumes that checking for
Not yet. The functions with a statement like this are:
All of them are tagged It might be necessary to change them to
Should I go ahead and make these changes in the context of this PR?
As
I am hesitant about renaming, because of the overloading of the word The spec uses |
This PR adds support for the XQuery 4.0
trustedoption tofn:doc,fn:doc-available,fn:parse-xml, andfn:parse-xml-fragment.It also renames
xsi-schema-locationtouse-xsi-schema-location(this is a breaking change).External-resource features are now protected on two levels:
Perm.CREATEis required for options that may trigger external access (dtd,dtd-validation,xinclude, anduse-xsi-schema-locationwith active XSD validation)trustedoption decides whether this access is actually allowed, otherwiseFODC0016is raiseddtd-validationmay now trigger external DTD loading independently ofdtd.The implementation-defined default for omitted fn-level
trustedis controlled byFNXMLTRUSTED. It defaults totruefor backwards-compatible behavior. The QT3 test driver setsFNXMLTRUSTEDtofalseto test the spec default.